Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-06-09 Thread Andy Shevchenko
On Fri, Jun 9, 2017 at 11:29 AM, Pali Rohár wrote: > On Thursday 08 June 2017 08:16:18 Darren Hart wrote: >> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: >> > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: >> > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: >>

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-06-09 Thread Pali Rohár
On Thursday 08 June 2017 08:16:18 Darren Hart wrote: > On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: > > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: > > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: > > >> On Sat, May 27, 2017 at 4:17 PM, Pali Rohár > > >> w

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-06-08 Thread Pali Rohár
On Thursday 08 June 2017 19:44:39 Andy Shevchenko wrote: > On Thu, Jun 8, 2017 at 8:42 PM, Andy Shevchenko > > wrote: > > On Thu, Jun 8, 2017 at 6:38 PM, Joe Perches wrote: > >> On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote: > >>> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-06-08 Thread Andy Shevchenko
On Thu, Jun 8, 2017 at 8:42 PM, Andy Shevchenko wrote: > On Thu, Jun 8, 2017 at 6:38 PM, Joe Perches wrote: >> On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote: >>> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: >>> > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: >>>

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-06-08 Thread Andy Shevchenko
On Thu, Jun 8, 2017 at 6:38 PM, Joe Perches wrote: > On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote: >> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: >> > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: >> > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: >>

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-06-08 Thread Joe Perches
On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote: > On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: > > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: > > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: > > > > On Sat, May 27, 2017 at 4:17 PM, Pali Rohár > > >

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-06-08 Thread Darren Hart
On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: > >> On Sat, May 27, 2017 at 4:17 PM, Pali Rohár > >> wrote: > > >> Okay, got it. But on your opinion does it make se

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-05-27 Thread Andy Shevchenko
On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: >> On Sat, May 27, 2017 at 4:17 PM, Pali Rohár >> wrote: >> Okay, got it. But on your opinion does it make sense to do >> >> pr_info("\tobject_id: %2pE\n", g->object_id); >> >> instead?

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-05-27 Thread Pali Rohár
On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: > On Sat, May 27, 2017 at 4:17 PM, Pali Rohár > wrote: > > On Saturday 27 May 2017 15:07:09 Andy Shevchenko wrote: > >> On Sat, May 27, 2017 at 2:51 PM, Pali Rohár > >> > >> wrote: > >> > Remove > >> > also reserved member as it does not ha

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-05-27 Thread Andy Shevchenko
On Sat, May 27, 2017 at 4:17 PM, Pali Rohár wrote: > On Saturday 27 May 2017 15:07:09 Andy Shevchenko wrote: >> On Sat, May 27, 2017 at 2:51 PM, Pali Rohár >> wrote: >> > Remove >> > also reserved member as it does not have any defined meaning or >> > type yet. >> > - pr_info("\treserved:

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-05-27 Thread Pali Rohár
On Saturday 27 May 2017 15:17:29 Pali Rohár wrote: > On Saturday 27 May 2017 15:07:09 Andy Shevchenko wrote: > > On Sat, May 27, 2017 at 2:51 PM, Pali Rohár > > > > wrote: > > > object_id and notify_id are in one union structure and their > > > meaning is defined by flags. Therefore do not print

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-05-27 Thread Pali Rohár
On Saturday 27 May 2017 15:07:09 Andy Shevchenko wrote: > On Sat, May 27, 2017 at 2:51 PM, Pali Rohár > wrote: > > object_id and notify_id are in one union structure and their > > meaning is defined by flags. Therefore do not print notify_id for > > non-event block and do not print object_id for e

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

2017-05-27 Thread Andy Shevchenko
On Sat, May 27, 2017 at 2:51 PM, Pali Rohár wrote: > object_id and notify_id are in one union structure and their meaning is > defined by flags. Therefore do not print notify_id for non-event block and > do not print object_id for event block. Remove also reserved member as it > does not have any