Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-18 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Dmitry, On Fri, 2017-02-17 at 11:52 -0800, Dmitry Torokhov wrote: > OK, if firmware disables the touchpad automatically, then it is fine. > > I am wondering about the utility of the new interface though. Are there > already major users of it?

Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-17 Thread Dmitry Torokhov
On Fri, Feb 17, 2017 at 02:49:00PM +0530, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hello Dmitry, > > On Fri, 2017-02-17 at 00:48 -0800, Dmitry Torokhov wrote: > > It looks like the patch is trying to provide a way to disable the > > touchpad when transition

Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-17 Thread Ritesh Raj Sarraf
On Fri, 2017-02-17 at 14:35 +0530, Ritesh Raj Sarraf wrote: > > Please use: > > > > static DEVICE_ATTR_RW(touchpad_mode); > > > > You'll need to move the show_ and store_ prefixes to be postfixes, see > > toshiba-acpi.c for several examples. > > > > Thank you. I am building the kernel the test/

Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-17 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Dmitry, On Fri, 2017-02-17 at 00:48 -0800, Dmitry Torokhov wrote: > It looks like the patch is trying to provide a way to disable the > touchpad when transitioning in tablet mode. The keyboard/touchpad get disabled, by hardware, when flipped

Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-17 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Darren, On Thu, 2017-02-16 at 19:33 -0800, Darren Hart wrote: > On Tue, Feb 14, 2017 at 07:46:12PM +0530, Ritesh Raj Sarraf wrote: > > > > > That said, we need to make these systems usable, and as there appears not to > be > an accepted stan

Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-17 Thread Dmitry Torokhov
On Fri, Feb 17, 2017 at 09:39:20AM +0200, Andy Shevchenko wrote: > On Fri, Feb 17, 2017 at 5:33 AM, Darren Hart wrote: > > On Tue, Feb 14, 2017 at 07:46:12PM +0530, Ritesh Raj Sarraf wrote: > >> Lenovo Yoga (many variants: Yoga, Yoga2 Pro, Yoga2 13, Yoga3 Pro, Yoga 3 > >> 14 etc) has multiple modl

Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-16 Thread Andy Shevchenko
On Fri, Feb 17, 2017 at 5:33 AM, Darren Hart wrote: > On Tue, Feb 14, 2017 at 07:46:12PM +0530, Ritesh Raj Sarraf wrote: >> Lenovo Yoga (many variants: Yoga, Yoga2 Pro, Yoga2 13, Yoga3 Pro, Yoga 3 >> 14 etc) has multiple modles that are a hybrid laptop, working in laptop >> mode as well as tablet

Re: [PATCH] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-16 Thread Darren Hart
On Tue, Feb 14, 2017 at 07:46:12PM +0530, Ritesh Raj Sarraf wrote: > Lenovo Yoga (many variants: Yoga, Yoga2 Pro, Yoga2 13, Yoga3 Pro, Yoga 3 > 14 etc) has multiple modles that are a hybrid laptop, working in laptop > mode as well as tablet mode. > > Currently, there is no easy interface to determ