Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-26 Thread Darren Hart
On Sat, Jun 23, 2018 at 08:24:26AM +0200, Julia Lawall wrote: > > > On Fri, 22 Jun 2018, Darren Hart wrote: > > > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > The function dell_smbios_smm_call and pointer platform_device are > > > local to t

Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-26 Thread Darren Hart
On Tue, Jun 26, 2018 at 10:32:17PM +0300, Andy Shevchenko wrote: > On Sat, Jun 23, 2018 at 3:22 AM, Darren Hart wrote: > > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The function dell_smbios_smm_call and pointer platform_device are > >> local t

Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-26 Thread Andy Shevchenko
On Sat, Jun 23, 2018 at 3:22 AM, Darren Hart wrote: > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The function dell_smbios_smm_call and pointer platform_device are >> local to the source and do not need to be in global scope, so make >> them static. >

Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-22 Thread Julia Lawall
On Fri, 22 Jun 2018, Darren Hart wrote: > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The function dell_smbios_smm_call and pointer platform_device are > > local to the source and do not need to be in global scope, so make > > them static. > > >

Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-22 Thread Darren Hart
On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote: > From: Colin Ian King > > The function dell_smbios_smm_call and pointer platform_device are > local to the source and do not need to be in global scope, so make > them static. > > Cleans up sparse warnings: > warning: symbol 'platform_