Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-04-01 Thread Kirill Kapranov
Fri, 29/03/2013 14:38 -0400, David Miller пишет: > Why are you posting this again? I've applied your patch 3 days > ago. oops... The last letter I sent was a coding style correction -- removing trailing whitespace in response to remark of Tue, 26 Mar 2013 12:59:13 -0400 (EDT) by David Miller: >

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-29 Thread David Miller
From: Kirill Kapranov Date: Tue, 26 Mar 2013 17:34:32 +0400 > In case of fixed speed set up for a NIC (e.g. ethtool -s eth0 autoneg off > speed > 100 duplex full) with an ethernet cable plugged off, the mentioned algorithm > slows down a NIC speed, so further cable hook-up leads to nonoperable l

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-27 Thread David Miller
From: Kirill Kapranov Date: Wed, 27 Mar 2013 15:16:13 +0400 > In case of fixed speed set up for a NIC (e.g. ethtool -s eth0 autoneg off > speed > 100 duplex full) with an ethernet cable plugged off, the mentioned algorithm > slows down a NIC speed, so further cable hook-up leads to nonoperable l

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-26 Thread David Miller
From: Kirill Kapranov Date: Tue, 26 Mar 2013 17:34:32 +0400 > - phy_force_reduction(phydev); > + if (0 == phydev->link_timeout--) Trailing whitespace, please remo

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-26 Thread David Miller
From: Kirill Kapranov Date: Tue, 26 Mar 2013 18:56:32 +0400 > Does the absence of criticism mean that this patch is ready for > upstream? You were given feedback on coding style, did you address and fix these issues in the submission you made today? -- To unsubscribe from this list: send the lin

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-26 Thread Kirill Kapranov
Does the absence of criticism mean that this patch is ready for upstream? Maybe I shall write more verbose explanation additionally? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-15 Thread Kirill Kapranov
15/03/2013 08:35 -0400, David Miller wrote: > From: Kirill Kapranov > Date: Thu, 14 Mar 2013 14:40:52 +0400 > > > @@ -867,7 +821,6 @@ void phy_state_machine(struct work_struct *work) > > netif_carrier_on(phydev->attached_dev); > > } else { > >

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-15 Thread David Miller
From: Joe Perches Date: Fri, 15 Mar 2013 05:48:49 -0700 > The phy code also uses non standard kernel style tests like > if (CONSTANT == variable) > instead of > if (variable == CONSTANT) Right, to trigger compile time errors when "=" is accidently used instead of "==". But the whole

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-15 Thread Joe Perches
On Fri, 2013-03-15 at 08:35 -0400, David Miller wrote: > From: Kirill Kapranov > Date: Thu, 14 Mar 2013 14:40:52 +0400 > > > @@ -867,7 +821,6 @@ void phy_state_machine(struct work_struct *work) > > netif_carrier_on(phydev->attached_dev); > > } e

Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

2013-03-15 Thread David Miller
From: Kirill Kapranov Date: Thu, 14 Mar 2013 14:40:52 +0400 > @@ -867,7 +821,6 @@ void phy_state_machine(struct work_struct *work) > netif_carrier_on(phydev->attached_dev); > } else { > if (0 == phydev->link_timeout