Re: [PATCH] phy: Add MOXA RTL8201CP PHY support

2013-11-11 Thread Grant Likely
On Mon, 4 Nov 2013 09:51:24 -0800, Florian Fainelli wrote: > 2013/11/4 Jonas Jensen : > > This is why I ended up setting PHY_IGNORE_INTERRUPT and the comment > > about its effectiveness. Polling works but the extra reads on the bus > > seem unnecessary. > > Ideas how they can be eliminated are ap

Re: [PATCH] phy: Add MOXA RTL8201CP PHY support

2013-11-04 Thread Florian Fainelli
2013/11/4 Jonas Jensen : > Thanks for the replies. > > On 1 November 2013 18:01, Florian Fainelli wrote: >>> + dev_err(&bus->dev, "%s timed out\n", __func__); >> >> I would keep these as a debugging aid and not spawn error messages on >> the console by default. > > Done. > > >>> + snpr

Re: [PATCH] phy: Add MOXA RTL8201CP PHY support

2013-11-04 Thread Jonas Jensen
Thanks for the replies. On 1 November 2013 18:01, Florian Fainelli wrote: >> + dev_err(&bus->dev, "%s timed out\n", __func__); > > I would keep these as a debugging aid and not spawn error messages on > the console by default. Done. >> + snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii",

Re: [PATCH] phy: Add MOXA RTL8201CP PHY support

2013-11-02 Thread Grant Likely
On Fri, 1 Nov 2013 15:54:33 +0100, Jonas Jensen wrote: > The MOXA UC-711X hardware(s) has an ethernet controller that seem > to be developed internally. The IC used is "RTL8201CP". > > This patch adds an MDIO driver and also patches realtek to include > RTL8201CP PHY driver. > > Signed-off-by:

Re: [PATCH] phy: Add MOXA RTL8201CP PHY support

2013-11-01 Thread Kishon Vijay Abraham I
Hi Jonas, On Friday 01 November 2013 08:24 PM, Jonas Jensen wrote: The MOXA UC-711X hardware(s) has an ethernet controller that seem to be developed internally. The IC used is "RTL8201CP". This patch adds an MDIO driver and also patches realtek to include RTL8201CP PHY driver. Signed-off-by:

Re: [PATCH] phy: Add MOXA RTL8201CP PHY support

2013-11-01 Thread Florian Fainelli
Hello Jonas, 2013/11/1 Jonas Jensen : > The MOXA UC-711X hardware(s) has an ethernet controller that seem > to be developed internally. The IC used is "RTL8201CP". > > This patch adds an MDIO driver and also patches realtek to include > RTL8201CP PHY driver. > > Signed-off-by: Jonas Jensen > ---