Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags

2018-01-23 Thread Jin, Yao
On 1/23/2018 10:40 PM, Jiri Olsa wrote: On Tue, Jan 23, 2018 at 07:02:44AM +0800, Jin, Yao wrote: SNIP threads = thread_map__new_str(target->pid, target->tid, target->uid, - target->per_thread); + target->per_t

Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags

2018-01-23 Thread Jiri Olsa
On Tue, Jan 23, 2018 at 07:02:44AM +0800, Jin, Yao wrote: SNIP > > > threads = thread_map__new_str(target->pid, target->tid, > > > target->uid, > > > - target->per_thread); > > > + target->per_thread && > > > targe

Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags

2018-01-22 Thread Jin, Yao
On 1/23/2018 7:56 AM, Mathieu Poirier wrote: On 22 January 2018 at 15:15, Jin Yao wrote: Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map: Enumerate all threads from /proc") that it has negative impact on 'perf record --per-thread'. It has the effect of creating a kernel

Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags

2018-01-22 Thread Mathieu Poirier
On 22 January 2018 at 15:15, Jin Yao wrote: > Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map: > Enumerate all threads from /proc") that it has negative impact on > 'perf record --per-thread'. It has the effect of creating a kernel event > for each thread in the system for '

Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags

2018-01-22 Thread Mathieu Poirier
On 22 January 2018 at 16:02, Jin, Yao wrote: > > > On 1/23/2018 5:10 AM, Mathieu Poirier wrote: >> >> On 22 January 2018 at 15:15, Jin Yao wrote: >>> >>> Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map: >>> Enumerate all threads from /proc") that it has negative impact on >

Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags

2018-01-22 Thread Jin, Yao
On 1/23/2018 5:10 AM, Mathieu Poirier wrote: On 22 January 2018 at 15:15, Jin Yao wrote: Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map: Enumerate all threads from /proc") that it has negative impact on 'perf record --per-thread'. It has the effect of creating a kernel

Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags

2018-01-22 Thread Mathieu Poirier
On 22 January 2018 at 15:15, Jin Yao wrote: > Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map: > Enumerate all threads from /proc") that it has negative impact on > 'perf record --per-thread'. It has the effect of creating a kernel event > for each thread in the system for '