Re: [PATCH] perf tools: Remove cast of non-varadic function to varadic

2013-11-01 Thread Namhyung Kim
Hi Arnaldo and Michael, On Thu, 31 Oct 2013 18:09:50 -0200, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 31, 2013 at 12:50:25PM -0700, Michael Hudson-Doyle escreveu: >> 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of >> percent_color_snprintf to a function pointer type w

Re: [PATCH] perf tools: Remove cast of non-varadic function to varadic

2013-10-31 Thread Michael Hudson-Doyle
Arnaldo Carvalho de Melo writes: > Em Thu, Oct 31, 2013 at 12:50:25PM -0700, Michael Hudson-Doyle escreveu: >> 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of >> percent_color_snprintf to a function pointer type with varargs. Change >> percent_color_snprintf to be varad

Re: [PATCH] perf tools: Remove cast of non-varadic function to varadic

2013-10-31 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 31, 2013 at 12:50:25PM -0700, Michael Hudson-Doyle escreveu: > 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of > percent_color_snprintf to a function pointer type with varargs. Change > percent_color_snprintf to be varadic and remove the cast. > > The symptom

Re: [PATCH] perf tools: Remove cast of non-varadic function to varadic

2013-10-31 Thread Will Deacon
Hi Michael, On Thu, Oct 31, 2013 at 07:50:25PM +, Michael Hudson-Doyle wrote: > 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of > percent_color_snprintf to a function pointer type with varargs. Change > percent_color_snprintf to be varadic and remove the cast. nit: