Re: [PATCH] perf metricgroup: Fix segmentation fault for metrics with no pmu event

2021-03-05 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 03, 2021 at 08:28:23AM +, John Garry escreveu: > On 03/02/2021 00:46, Jin, Yao wrote: > > > > > > This should be fixed in v5.11-rc6 - please check it. > > > > > > 9c880c24cb0d perf metricgroup: Fix for metrics containing duration_time > > > > > > Thanks, > > > John > > > > Oh, I

Re: [PATCH] perf metricgroup: Fix segmentation fault for metrics with no pmu event

2021-02-03 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 03, 2021 at 08:46:52AM +0800, Jin, Yao escreveu: > On 2/2/2021 4:15 PM, John Garry wrote: > > On 02/02/2021 02:24, Jin Yao wrote: > > > It causes the segmentation fault. Now check the pmu_name before strcmp. > > > Fixes: c2337d67199a("perf metricgroup: Fix metrics using aliases coverin

Re: [PATCH] perf metricgroup: Fix segmentation fault for metrics with no pmu event

2021-02-03 Thread John Garry
On 03/02/2021 00:46, Jin, Yao wrote: This should be fixed in v5.11-rc6 - please check it. 9c880c24cb0d perf metricgroup: Fix for metrics containing duration_time Thanks, John Oh, I see, your patch is in Arnaldo's perf/urgent branch. Sorry about that, I just tested Arnaldo's perf/core branch

Re: [PATCH] perf metricgroup: Fix segmentation fault for metrics with no pmu event

2021-02-02 Thread Jin, Yao
Hi John, On 2/2/2021 4:15 PM, John Garry wrote: On 02/02/2021 02:24, Jin Yao wrote: Hit a segmentation fault for DRAM_BW_Use on SKL/KBL.    # perf stat -M DRAM_BW_Use -a -- sleep 1    Segmentation fault (core dumped)    (gdb) backtrace    #0  __strcmp_sse2_unaligned () at ../sysdeps/x86_64/

Re: [PATCH] perf metricgroup: Fix segmentation fault for metrics with no pmu event

2021-02-02 Thread John Garry
On 02/02/2021 02:24, Jin Yao wrote: Hit a segmentation fault for DRAM_BW_Use on SKL/KBL. # perf stat -M DRAM_BW_Use -a -- sleep 1 Segmentation fault (core dumped) (gdb) backtrace #0 __strcmp_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:31 #1 0x