Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-28 Thread Ian Rogers
On Wed, May 27, 2020 at 9:39 PM Nick Gasson wrote: > > On 05/28/20 02:08 AM, Ian Rogers wrote: > >> > >> I noticed it loses information when the Hotspot code cache is > >> resized. I've been working around that by setting > >> -XX:InitialCodeCacheSize and -XX:ReservedCodeCacheSize to large > >> va

Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-27 Thread Nick Gasson
On 05/28/20 02:08 AM, Ian Rogers wrote: >> >> I noticed it loses information when the Hotspot code cache is >> resized. I've been working around that by setting >> -XX:InitialCodeCacheSize and -XX:ReservedCodeCacheSize to large >> values. Does this help in your case? > > Thanks, I tried and also wi

Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-27 Thread Ian Rogers
On Tue, May 26, 2020 at 10:40 PM Nick Gasson wrote: > > On 05/27/20 13:03 PM, Ian Rogers wrote: > > > > Great result, thanks! I note there is a lack of symbolization when > > benchmarking a few Java applications. I'll try to see if there's a > > sensible resolution for those. > > > > I noticed it

Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-27 Thread Arnaldo Carvalho de Melo
On May 27, 2020 2:29:05 AM GMT-03:00, Nick Gasson wrote: >On 05/26/20 19:55 PM, Jiri Olsa wrote: >> On Fri, May 22, 2020 at 02:53:30PM +0800, Nick Gasson wrote: >>> For each PC/BCI pair in the JVMTI compiler inlining record table, >the >>> jitdump plugin emits debug line table entries for every

Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-26 Thread Nick Gasson
On 05/27/20 13:03 PM, Ian Rogers wrote: > > Great result, thanks! I note there is a lack of symbolization when > benchmarking a few Java applications. I'll try to see if there's a > sensible resolution for those. > I noticed it loses information when the Hotspot code cache is resized. I've been wo

Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-26 Thread Nick Gasson
On 05/26/20 19:55 PM, Jiri Olsa wrote: > On Fri, May 22, 2020 at 02:53:30PM +0800, Nick Gasson wrote: >> For each PC/BCI pair in the JVMTI compiler inlining record table, the >> jitdump plugin emits debug line table entries for every source line in >> the method preceding that BCI. Instead only emi

Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-26 Thread Ian Rogers
On Thu, May 21, 2020 at 11:54 PM Nick Gasson wrote: > > For each PC/BCI pair in the JVMTI compiler inlining record table, the > jitdump plugin emits debug line table entries for every source line in > the method preceding that BCI. Instead only emit one source line per > PC/BCI pair. Reported by I

Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

2020-05-26 Thread Jiri Olsa
On Fri, May 22, 2020 at 02:53:30PM +0800, Nick Gasson wrote: > For each PC/BCI pair in the JVMTI compiler inlining record table, the > jitdump plugin emits debug line table entries for every source line in > the method preceding that BCI. Instead only emit one source line per > PC/BCI pair. Reporte