Re: [PATCH] perf data: export to JSON

2021-04-01 Thread Jiri Olsa
On Wed, Mar 31, 2021 at 06:38:16AM -0400, Nicholas Fraser wrote: > Hi Jiri, > > Thanks for the review. I've addressed your suggestions; some notes are > below. I'll send a new patch. > > > On 2021-03-24 2:20 p.m., Jiri Olsa wrote: > > On Wed, Mar 24, 2021 at 09:06:50AM -0400, Nicholas Fraser wro

Re: [PATCH] perf data: export to JSON

2021-03-31 Thread Nicholas Fraser
Hi Jiri, Thanks for the review. I've addressed your suggestions; some notes are below. I'll send a new patch. On 2021-03-24 2:20 p.m., Jiri Olsa wrote: > On Wed, Mar 24, 2021 at 09:06:50AM -0400, Nicholas Fraser wrote: >> [...] We use this to import the data into a tool on Windows >> where integ

Re: [PATCH] perf data: export to JSON

2021-03-31 Thread Nicholas Fraser
Hi Arnaldo, Thanks for the review. I'll send a replacement patch with your suggestions. On 2021-03-24 9:30 a.m., Arnaldo Carvalho de Melo wrote: > Do you plan to output the headers too? I think we should, for > completeness. I've added the headers, at least the ones that seemed important or easy

Re: [PATCH] perf data: export to JSON

2021-03-24 Thread Jiri Olsa
On Wed, Mar 24, 2021 at 09:06:50AM -0400, Nicholas Fraser wrote: > This adds preliminary support to dump the contents of a perf.data file to > human-readable JSON. > > The "perf data" command currently only supports exporting to Common Trace > Format and it doesn't do symbol resolution among other

Re: [PATCH] perf data: export to JSON

2021-03-24 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 24, 2021 at 09:06:50AM -0400, Nicholas Fraser escreveu: > This adds preliminary support to dump the contents of a perf.data file to > human-readable JSON. > > The "perf data" command currently only supports exporting to Common Trace > Format and it doesn't do symbol resolution among ot