Re: [PATCH] perf annotate: pass filename to objdump via execl

2019-01-04 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 30, 2018 at 05:37:43PM +0300, Ivan Krylov escreveu: > On Sun, 14 Oct 2018 16:04:51 +0200 > Jiri Olsa wrote: > > > Acked-by: Jiri Olsa > > Is there anything I could do to improve the patch? Should I wrap the > path to objdump executable in a similar way? Nope, just fell thru the hol

Re: [PATCH] perf annotate: pass filename to objdump via execl

2018-12-30 Thread Ivan Krylov
On Sun, 14 Oct 2018 16:04:51 +0200 Jiri Olsa wrote: > Acked-by: Jiri Olsa Is there anything I could do to improve the patch? Should I wrap the path to objdump executable in a similar way? -- Best regards, Ivan

Re: [PATCH] perf annotate: pass filename to objdump via execl

2018-10-14 Thread Jiri Olsa
On Sun, Oct 14, 2018 at 11:18:03AM +0300, Ivan Krylov wrote: > The symbol__disassemble() function uses shell to launch objdump and filter > its output via grep. Passing filenames by interpolating them into the > command line via "%s" may lead to problems if said filenames contain > special characte