Re: [PATCH] perf: fix confusing messages when not able to read trace events files

2015-08-24 Thread Jiri Olsa
On Thu, Aug 20, 2015 at 02:52:01PM +0100, Matt Fleming wrote: SNIP > > The err variable doesn't go down to the add_tracepoint_multi_event() > > call. It actually stops in parse_events_parse() where > > parse_events_add_tracepoint is being called using only the idx part of > > data (util/parse-eve

Re: [PATCH] perf: fix confusing messages when not able to read trace events files

2015-08-20 Thread Matt Fleming
On Tue, 18 Aug, at 01:45:00PM, Raphaël Beamonte wrote: > > debugfs__strerror_open_tp is using that call to form the path: > snprintf(path, PATH_MAX, "tracing/events/%s/%s", sys, name ?: "*"); > > Where for add_tracepoint_multi_sys we just need the tracing/events > part, and for add_tracep

Re: [PATCH] perf: fix confusing messages when not able to read trace events files

2015-08-18 Thread Raphaël Beamonte
2015-08-18 7:43 GMT-04:00 Matt Fleming : >> - perror("Can't open event dir"); >> + debugfs__strerror_open( >> + errno, errbuf, sizeof(errbuf), >> + evt_path + strlen(debugfs_mountpoint) + 1); > > The way the filename is passed seems a

Re: [PATCH] perf: fix confusing messages when not able to read trace events files

2015-08-18 Thread Matt Fleming
On Sun, 16 Aug, at 09:39:12PM, Raphaël Beamonte wrote: > If a non-root user tries to specify a trace event and the tracefs > files can't be read, it will tell about it in a somewhat cryptic > way and as well say that the tracepoint is unknown, which is > obvious, since the tracefs files were not re