Re: [PATCH] perf: disable mmap2 support

2013-10-15 Thread Ingo Molnar
* Stephane Eranian wrote: > On Tue, Oct 15, 2013 at 3:34 PM, Ingo Molnar wrote: > > > > * Stephane Eranian wrote: > > > >> On Tue, Oct 15, 2013 at 3:12 PM, Ingo Molnar wrote: > >> > > >> > * Stephane Eranian wrote: > >> > > >> >> Arnaldo, > >> >> > >> >> Could you revert all the mmap2 patche

Re: [PATCH] perf: disable mmap2 support

2013-10-15 Thread Stephane Eranian
On Tue, Oct 15, 2013 at 3:34 PM, Ingo Molnar wrote: > > * Stephane Eranian wrote: > >> On Tue, Oct 15, 2013 at 3:12 PM, Ingo Molnar wrote: >> > >> > * Stephane Eranian wrote: >> > >> >> Arnaldo, >> >> >> >> Could you revert all the mmap2 patches in your perf/urgent tree for now? >> >> Thanks. >

Re: [PATCH] perf: disable mmap2 support

2013-10-15 Thread Ingo Molnar
* Stephane Eranian wrote: > On Tue, Oct 15, 2013 at 3:12 PM, Ingo Molnar wrote: > > > > * Stephane Eranian wrote: > > > >> Arnaldo, > >> > >> Could you revert all the mmap2 patches in your perf/urgent tree for now? > >> Thanks. > > > > I think it would be helpful if you re-sent the final patch

Re: [PATCH] perf: disable mmap2 support

2013-10-15 Thread Stephane Eranian
On Tue, Oct 15, 2013 at 3:12 PM, Ingo Molnar wrote: > > * Stephane Eranian wrote: > >> Arnaldo, >> >> Could you revert all the mmap2 patches in your perf/urgent tree for now? >> Thanks. > > I think it would be helpful if you re-sent the final patch, with a full > changelog, etc., in a separate th

Re: [PATCH] perf: disable mmap2 support

2013-10-15 Thread Ingo Molnar
* Stephane Eranian wrote: > Arnaldo, > > Could you revert all the mmap2 patches in your perf/urgent tree for now? > Thanks. I think it would be helpful if you re-sent the final patch, with a full changelog, etc., in a separate thread, not inside an existing discussion and such. Thanks,

Re: [PATCH] perf: disable mmap2 support

2013-10-15 Thread Stephane Eranian
Arnaldo, Could you revert all the mmap2 patches in your perf/urgent tree for now? Thanks. On Fri, Oct 11, 2013 at 8:40 PM, David Ahern wrote: > Hi Stephane: > > > On 10/9/13 11:40 AM, Stephane Eranian wrote: >> >> On Wed, Oct 9, 2013 at 7:19 PM, David Ahern wrote: >>> >>> On 10/9/13 10:39 AM, S

Re: [PATCH] perf: disable mmap2 support

2013-10-11 Thread David Ahern
Hi Stephane: On 10/9/13 11:40 AM, Stephane Eranian wrote: On Wed, Oct 9, 2013 at 7:19 PM, David Ahern wrote: On 10/9/13 10:39 AM, Stephane Eranian wrote: Looks like the easiest thing to do for perf is to revert: Revert "perf tools: Add default handler for mmap2 events" git revert

Re: [PATCH] perf: disable mmap2 support

2013-10-10 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 09, 2013 at 12:03:58PM -0600, David Ahern escreveu: > On 10/9/13 11:40 AM, Stephane Eranian wrote: > >On Wed, Oct 9, 2013 at 7:19 PM, David Ahern wrote: > >>On 10/9/13 10:39 AM, Stephane Eranian wrote: > >You mean: > >commit 384c671e33a7ddf905f2c60b433b9883f0e5a605 > >Author: David Ahe

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 09, 2013 at 06:17:43PM +0200, Stephane Eranian escreveu: > > This patch disables the mmap2 record format support for now. The > > support needs a bit more work to cover VM_CLONE cases. > > > > The patch leaves attr->mmap2 defined, but returns an

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 09, 2013 at 06:17:43PM +0200, Stephane Eranian escreveu: > This patch disables the mmap2 record format support > for now. The support needs a bit more work to cover > VM_CLONE cases. > > The patch leaves attr->mmap2 defined, but returns > an error if it is set. That ensures no PERF_REC

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread David Ahern
On 10/9/13 11:40 AM, Stephane Eranian wrote: On Wed, Oct 9, 2013 at 7:19 PM, David Ahern wrote: On 10/9/13 10:39 AM, Stephane Eranian wrote: Looks like the easiest thing to do for perf is to revert: Revert "perf tools: Add default handler for mmap2 events" git revert 6adb0b0ae26fcc

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread Stephane Eranian
On Wed, Oct 9, 2013 at 7:19 PM, David Ahern wrote: > On 10/9/13 10:39 AM, Stephane Eranian wrote: >> >> Looks like the easiest thing to do for perf is to revert: >> >> Revert "perf tools: Add default handler for mmap2 events" >> git revert 6adb0b0ae26fcc35cfec068d71f13863faac5b44 >> >>

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread David Ahern
On 10/9/13 10:39 AM, Stephane Eranian wrote: Looks like the easiest thing to do for perf is to revert: Revert "perf tools: Add default handler for mmap2 events" git revert 6adb0b0ae26fcc35cfec068d71f13863faac5b44 Revert "perf tools: Add attr->mmap2 support" git revert 5c5e854bc7

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread Stephane Eranian
On Wed, Oct 9, 2013 at 6:24 PM, Stephane Eranian wrote: > On Wed, Oct 9, 2013 at 6:21 PM, David Ahern wrote: >> On 10/9/13 10:17 AM, Stephane Eranian wrote: >>> >>> >>> This patch disables the mmap2 record format support >>> for now. The support needs a bit more work to cover >>> VM_CLONE cases.

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread Stephane Eranian
On Wed, Oct 9, 2013 at 6:21 PM, David Ahern wrote: > On 10/9/13 10:17 AM, Stephane Eranian wrote: >> >> >> This patch disables the mmap2 record format support >> for now. The support needs a bit more work to cover >> VM_CLONE cases. >> >> The patch leaves attr->mmap2 defined, but returns >> an err

Re: [PATCH] perf: disable mmap2 support

2013-10-09 Thread David Ahern
On 10/9/13 10:17 AM, Stephane Eranian wrote: This patch disables the mmap2 record format support for now. The support needs a bit more work to cover VM_CLONE cases. The patch leaves attr->mmap2 defined, but returns an error if it is set. That ensures no PERF_RECORD_MMAP2 record can be generated