Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Peter Zijlstra
On Tue, Sep 01, 2020 at 12:58:34PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 01, 2020 at 05:12:04PM +0200, pet...@infradead.org escreveu: > > On Tue, Sep 01, 2020 at 12:06:30PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > Also you mixed up tools/ with include/ things, the perf part

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread peterz
On Tue, Sep 01, 2020 at 12:06:30PM -0300, Arnaldo Carvalho de Melo wrote: > Also you mixed up tools/ with include/ things, the perf part of the > kernel is maintained by Ingo, PeterZ. Right, it helps if the right people are on Cc. > Peter, the patch is the one below, I'll collect the > tools/inc

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2020 at 05:12:04PM +0200, pet...@infradead.org escreveu: > On Tue, Sep 01, 2020 at 12:06:30PM -0300, Arnaldo Carvalho de Melo wrote: > > > Also you mixed up tools/ with include/ things, the perf part of the > > kernel is maintained by Ingo, PeterZ. > > Right, it helps if the right

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Al Grant
On 01/09/2020 16:02, Arnaldo Carvalho de Melo wrote: Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: pe

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2020 at 12:02:25PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: > > On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > > > > On Mon, Aug 24, 2020 at 1

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: > On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > > > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > > > > perf_event.h has macros that define the fiel

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Al Grant
On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE offs

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > > perf_event.h has macros that define the field offsets in the > > data_src bitmask in perf records. The SNOOPX and REMOTE offsets > > were both 37. These are distinct fields

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Mark Rutland
Hi, [ adding the kernel-side perf maintainers ] Please note that scripts/get_maintainer.pl can help to find relevant maintainers. On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > perf_event.h has macros that define the field offsets in the > data_src bitmask in perf records. The SNOOP

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-25 Thread Andi Kleen
On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > perf_event.h has macros that define the field offsets in the > data_src bitmask in perf records. The SNOOPX and REMOTE offsets > were both 37. These are distinct fields, and the bitfield layout > in perf_mem_data_src confirms that SNOOPX s