Re: [PATCH] perf/report: Report OOM in perf report status line

2019-04-26 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 26, 2019 at 04:44:06PM +0200, Jiri Olsa escreveu: > On Fri, Apr 26, 2019 at 11:16:07AM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > > util/session.c: In function ‘perf_session__process_events’: > > > util/session.c:1936:7: error: ‘skip’ may be used uninitialized in this > >

Re: [PATCH] perf/report: Report OOM in perf report status line

2019-04-26 Thread Jiri Olsa
On Fri, Apr 26, 2019 at 11:16:07AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > util/session.c: In function ‘perf_session__process_events’: > > util/session.c:1936:7: error: ‘skip’ may be used uninitialized in this > > function [-Werror=maybe-uninitialized] > >err = skip; > >^

Re: [PATCH] perf/report: Report OOM in perf report status line

2019-04-26 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 26, 2019 at 11:09:07AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 23, 2019 at 12:53:03PM +0200, Thomas Richter escreveu: > > An -ENOMEM error is not reported in the GTK GUI. > > Instead this error message pops up on the screen: > > > > [root@m35lp76 perf]# ./perf report -

Re: [PATCH] perf/report: Report OOM in perf report status line

2019-04-26 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 26, 2019 at 11:10:32AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Apr 26, 2019 at 11:09:07AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Apr 23, 2019 at 12:53:03PM +0200, Thomas Richter escreveu: > > > An -ENOMEM error is not reported in the GTK GUI. > > > Instead thi

Re: [PATCH] perf/report: Report OOM in perf report status line

2019-04-26 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 23, 2019 at 12:53:03PM +0200, Thomas Richter escreveu: > An -ENOMEM error is not reported in the GTK GUI. > Instead this error message pops up on the screen: > > [root@m35lp76 perf]# ./perf report -i perf.data.error68-1 > > Processing events... [974K/3M] > Error:failed to

Re: [PATCH] perf/report: Report OOM in perf report status line

2019-04-15 Thread Hendrik Brueckner
Thomas, On Mon, Apr 15, 2019 at 11:46:17AM +0200, Thomas Richter wrote: [...] > Signed-off-by: Thomas Richter > Reviewed-by: Jiri Olsa > --- > tools/perf/util/session.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/s