Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-21 Thread Grant Likely
On Sun, Jul 21, 2013 at 9:45 PM, Rob Herring wrote: > We can debate whether the driver order matters or not, but either way > I'm not sure this patch does the right thing. It doesn't really look > correct to me, but I haven't dug into it. > > We've already tried to fix matching and reverted the fi

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-21 Thread Rob Herring
On Sat, Jul 20, 2013 at 12:44 AM, Grant Likely wrote: > On Tue, 9 Jul 2013 16:10:53 +0800, Huang Shijie wrote: >> 于 2013年07月09日 15:51, Sascha Hauer 写道: >> > On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote: >> >> 于 2013年07月09日 15:05, Sascha Hauer 写道: >> >>> Why don't you set the match

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-20 Thread Thierry Reding
On Sat, Jul 20, 2013 at 06:44:39AM +0100, Grant Likely wrote: > On Tue, 9 Jul 2013 16:10:53 +0800, Huang Shijie wrote: > > 于 2013年07月09日 15:51, Sascha Hauer 写道: > > > On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote: > > >> 于 2013年07月09日 15:05, Sascha Hauer 写道: > > >>> Why don't you se

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-20 Thread Grant Likely
On Tue, 9 Jul 2013 16:10:53 +0800, Huang Shijie wrote: > 于 2013年07月09日 15:51, Sascha Hauer 写道: > > On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote: > >> 于 2013年07月09日 15:05, Sascha Hauer 写道: > >>> Why don't you set the matching order in the driver the way you w

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Huang Shijie
于 2013年07月09日 20:03, Rob Herring 写道: > the same and that is the assumption. Matching is not just based on > compatible properties and your patch does not handle the other cases. Could you show a example of "the other cases"? After this patch, [1] the matching will first check the @match->type and

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Stephen Warren
On 07/09/2013 06:03 AM, Rob Herring wrote: > On Tue, Jul 9, 2013 at 3:10 AM, Huang Shijie wrote: >> 于 2013年07月09日 15:51, Sascha Hauer 写道: >> >>> On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote: 于 2013年07月09日 15:05, Sascha Hauer 写道: > > Why don't you set the matching

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Stephen Warren
On 07/09/2013 01:05 AM, Sascha Hauer wrote: > On Fri, Jul 05, 2013 at 04:43:38PM +0800, Huang Shijie wrote: >> If we set the uart compatible in the dts file like this: >>-- >> compatible = "fsl,imx6q-uart", "fsl,imx21-uart"; >>

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Rob Herring
On Tue, Jul 9, 2013 at 3:10 AM, Huang Shijie wrote: > 于 2013年07月09日 15:51, Sascha Hauer 写道: > >> On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote: >>> >>> 于 2013年07月09日 15:05, Sascha Hauer 写道: Why don't you set the matching order in the driver the way you want it to be,

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Huang Shijie
于 2013年07月09日 15:51, Sascha Hauer 写道: On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote: 于 2013年07月09日 15:05, Sascha Hauer 写道: Why don't you set the matching order in the driver the way you want it to be, i.e.: { .compatible = "fsl,imx6q-uart", ... }, { .compatible =

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Sascha Hauer
On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote: > 于 2013年07月09日 15:05, Sascha Hauer 写道: > >Why don't you set the matching order in the driver the way you want it > >to be, i.e.: > > > > { .compatible = "fsl,imx6q-uart", ... }, > > { .compatible = "fsl,imx21-uart", ... }, > >

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Huang Shijie
于 2013年07月09日 15:05, Sascha Hauer 写道: Why don't you set the matching order in the driver the way you want it to be, i.e.: { .compatible = "fsl,imx6q-uart", ... }, { .compatible = "fsl,imx21-uart", ... }, { .compatible = "fsl,imx1-uart", ... }, yes. i can set it like thi

Re: [PATCH] of: match the compatible in the order set by the dts file

2013-07-09 Thread Sascha Hauer
On Fri, Jul 05, 2013 at 04:43:38PM +0800, Huang Shijie wrote: > If we set the uart compatible in the dts file like this: >-- > compatible = "fsl,imx6q-uart", "fsl,imx21-uart"; >-- >