Re: [PATCH] objtool: drop redundant flags generation

2017-03-07 Thread Nicholas Mc Guire
On Tue, Mar 07, 2017 at 02:55:21PM +0100, Masami Hiramatsu wrote: > On Tue, 7 Mar 2017 08:13:19 + > Nicholas Mc Guire wrote: > > > On Mon, Mar 06, 2017 at 03:40:54PM -0600, Josh Poimboeuf wrote: > > > On Mon, Mar 06, 2017 at 05:54:01PM +, Nicholas Mc Guire wrote: > > > > On Mon, Mar 06, 2

Re: [PATCH] objtool: drop redundant flags generation

2017-03-07 Thread Masami Hiramatsu
On Tue, 7 Mar 2017 08:13:19 + Nicholas Mc Guire wrote: > On Mon, Mar 06, 2017 at 03:40:54PM -0600, Josh Poimboeuf wrote: > > On Mon, Mar 06, 2017 at 05:54:01PM +, Nicholas Mc Guire wrote: > > > On Mon, Mar 06, 2017 at 11:25:37AM -0600, Josh Poimboeuf wrote: > > > > > arch/x86/tools/gen-i

Re: [PATCH] objtool: drop redundant flags generation

2017-03-07 Thread Nicholas Mc Guire
On Mon, Mar 06, 2017 at 03:40:54PM -0600, Josh Poimboeuf wrote: > On Mon, Mar 06, 2017 at 05:54:01PM +, Nicholas Mc Guire wrote: > > On Mon, Mar 06, 2017 at 11:25:37AM -0600, Josh Poimboeuf wrote: > > > > arch/x86/tools/gen-insn-attr-x86.awk | 12 ++-- > > > > tools/objtoo

Re: [PATCH] objtool: drop redundant flags generation

2017-03-07 Thread Masami Hiramatsu
On Mon, 6 Mar 2017 18:00:25 +0100 Nicholas Mc Guire wrote: > The generator was emitting quite a few duplicate flags which was making > doublebitand.cocci nervous. This awk hack resolves the duplicate issue. Yes, I know that. I don't think that the duplicating those flags in "automatic generated

Re: [PATCH] objtool: drop redundant flags generation

2017-03-06 Thread Josh Poimboeuf
On Mon, Mar 06, 2017 at 05:54:01PM +, Nicholas Mc Guire wrote: > On Mon, Mar 06, 2017 at 11:25:37AM -0600, Josh Poimboeuf wrote: > > > arch/x86/tools/gen-insn-attr-x86.awk | 12 ++-- > > > tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk | 12 ++-- > > > > There's

Re: [PATCH] objtool: drop redundant flags generation

2017-03-06 Thread Nicholas Mc Guire
On Mon, Mar 06, 2017 at 11:25:37AM -0600, Josh Poimboeuf wrote: > On Mon, Mar 06, 2017 at 06:00:25PM +0100, Nicholas Mc Guire wrote: > > The generator was emitting quite a few duplicate flags which was making > > doublebitand.cocci nervous. This awk hack resolves the duplicate issue. > > > > Signe

Re: [PATCH] objtool: drop redundant flags generation

2017-03-06 Thread Josh Poimboeuf
On Mon, Mar 06, 2017 at 06:00:25PM +0100, Nicholas Mc Guire wrote: > The generator was emitting quite a few duplicate flags which was making > doublebitand.cocci nervous. This awk hack resolves the duplicate issue. > > Signed-off-by: Nicholas Mc Guire > --- > > The coccinelle complaints emitted