Re: [PATCH] objtool, module: discard __unreachable section for modules

2017-03-01 Thread hpa
On March 1, 2017 9:01:54 AM PST, Linus Torvalds wrote: >On Wed, Mar 1, 2017 at 8:44 AM, wrote: >> >> I would like to see a name like, say, ".annot.unreachable", since is >odds are pretty high we are going to need more annotations in the >future. > >Why not just make it ".discard.unreachable", a

Re: [PATCH] objtool, module: discard __unreachable section for modules

2017-03-01 Thread Linus Torvalds
On Wed, Mar 1, 2017 at 8:44 AM, wrote: > > I would like to see a name like, say, ".annot.unreachable", since is odds are > pretty high we are going to need more annotations in the future. Why not just make it ".discard.unreachable", and then make the discard pattern be ".discard*". We already

Re: [PATCH] objtool, module: discard __unreachable section for modules

2017-03-01 Thread hpa
On March 1, 2017 7:20:03 AM PST, Josh Poimboeuf wrote: >The __unreachable section is only used at compile time. It's discarded >for vmlinux but it should also be discarded for modules. > >Fixes: d1091c7fa3d5 ("objtool: Improve detection of BUG() and other >dead ends") >Signed-off-by: Josh Poimboe