Re: [PATCH] nvdimm/pmem: Set dax flag for all 'PFN_MAP' cases

2024-08-08 Thread Alison Schofield
On Wed, Jul 31, 2024 at 08:25:30PM +0800, Zhihao Cheng wrote: > The dax is only supportted on pfn type pmem devices since commit > f467fee48da4 ("block: move the dax flag to queue_limits"), fix it > by adding dax flag setting for the missed case. s/supportted/supported How about adding failure me

Re: [PATCH] nvdimm/pmem: Set dax flag for all 'PFN_MAP' cases

2024-08-07 Thread Dave Jiang
On 7/31/24 5:25 AM, Zhihao Cheng wrote: > The dax is only supportted on pfn type pmem devices since commit > f467fee48da4 ("block: move the dax flag to queue_limits"), fix it > by adding dax flag setting for the missed case. > > Fixes: f467fee48da4 ("block: move the dax flag to queue_limits") >

Re: [PATCH] nvdimm/pmem: Set dax flag for all 'PFN_MAP' cases

2024-07-31 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig