Re: [PATCH] ntp: make is_error_status() use its argument

2014-05-12 Thread John Stultz
On 05/12/2014 08:01 PM, George Spelvin wrote: >> CONFIG_NTP_PPS not CONFIG_SMP, right? > D'oh, yes. I just noticed that there were two versions and one was > broken. Somehow my search for the enclosing #ifdef was completely broken. > (I could swear I saw CONFIG_SMP, but looking now it's not even

Re: [PATCH] ntp: make is_error_status() use its argument

2014-05-12 Thread George Spelvin
> CONFIG_NTP_PPS not CONFIG_SMP, right? D'oh, yes. I just noticed that there were two versions and one was broken. Somehow my search for the enclosing #ifdef was completely broken. (I could swear I saw CONFIG_SMP, but looking now it's not even mentioned in the file; maybe I switched editor windo

Re: [PATCH] ntp: make is_error_status() use its argument

2014-05-12 Thread Alexander Gordeev
No objections from me, of course. Good catch. В Mon, 12 May 2014 10:54:29 -0700 John Stultz пишет: > On 05/12/2014 06:35 AM, George Spelvin wrote: > > It's an inline function always called with the global time_status > > as an argument, so there's zero functional difference, but the > > non-CONF

Re: [PATCH] ntp: make is_error_status() use its argument

2014-05-12 Thread John Stultz
On 05/12/2014 06:35 AM, George Spelvin wrote: > It's an inline function always called with the global time_status as an > argument, so there's zero functional difference, but the non-CONFIG_SMP > version uses the passed-in argument, while the CONFIG_SMP one ignores > its argument and uses the globa