Re: [PATCH net 6/6] net: dsa: ksz: fix wrong read cast to u64

2021-01-13 Thread Vladimir Oltean
On Wed, Jan 13, 2021 at 01:45:22PM +0100, Gilles DOFFE wrote: > '(u64)*value' casts a u32 to a u64. So depending on endianness, > LSB or MSB is lost. > The pointer needs to be cast to read the full u64: > '*((u64 *)value)' > > Signed-off-by: Gilles DOFFE > --- Reviewed-by: Vladimir Oltean

Re: [PATCH net 6/7] netvsc: Initialize 64-bit stats seqcount

2017-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2017 12:11:12 -0700 Florian Fainelli wrote: > On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a > lockdep splat indicating this seqcount is not correctly initialized, fix > that. In commit 6c80f3fc2398 ("netvsc: report per-channel stats in > ethtool statistics"

Re: [PATCH net 6/9] virtio-net: make rx buf size estimation works for XDP

2016-12-23 Thread John Fastabend
On 16-12-23 06:37 AM, Jason Wang wrote: > We don't update ewma rx buf size in the case of XDP. This will lead > underestimation of rx buf size which causes host to produce more than > one buffers. This will greatly increase the possibility of XDP page > linearization. > > Cc: John Fastabend > Sig

Re: [PATCH net 6/7] openvswitch: Extend ct_state match field to 32 bits

2015-09-30 Thread Pravin Shelar
On Tue, Sep 29, 2015 at 3:39 PM, Joe Stringer wrote: > The ct_state field was initially added as an 8-bit field, however six of > the bits are already being used and use cases are already starting to > appear that may push the limits of this field. This patch extends the > field to 32 bits while r

Re: [PATCH] net #6

2001-05-31 Thread Alan Cox
> > They are done this way to get good non SMP performance. Your changes would > > ruin that. > > Maybe macro "spin_lock_irqsave_on_smp()" would be good idea? These > ifdefs look ugly. Maybe local to driver, maybe even global. I had that argument with Linus about globally and ended up with ifdef

Re: [PATCH] net #6

2001-05-31 Thread Pavel Machek
Hi! > They are neccessary > > > @@ -643,9 +631,7 @@ > > eexp_hw_tx_pio(dev,data,length); > > } > > dev_kfree_skb(buf); > > -#ifdef CONFIG_SMP > > spin_unlock_irqrestore(&lp->lock, flags); > > -#endif > > enable_irq(dev->irq); > > return 0; > > They are done this

Re: [PATCH] net #6

2001-05-30 Thread Andrzej Krzysztofowicz
> > > The following patch removes unnecessary #ifdefs from eexpress.c > > They are neccessary Yes, you are right. I was suggested by improper part of spinlock.h ... Forget this patch. > > @@ -643,9 +631,7 @@ > > eexp_hw_tx_pio(dev,data,length); > > } > > dev_kfree_skb(buf

Re: [PATCH] net #6

2001-05-30 Thread Alan Cox
> The following patch removes unnecessary #ifdefs from eexpress.c They are neccessary > @@ -643,9 +631,7 @@ > eexp_hw_tx_pio(dev,data,length); > } > dev_kfree_skb(buf); > -#ifdef CONFIG_SMP > spin_unlock_irqrestore(&lp->lock, flags); > -#endif > enable_irq(d