Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-23 Thread Vlad Yasevich
On 11/23/2013 06:14 AM, Chang wrote: > Hi, > Could you please why a **reneged** newly acked TSN doesn't qualify the > highest_new_tsn? What's the wrongs of doing that? > > I've been thinking a few scenarios, but I couldn't figure out what's > wrong with that. > The spec is a bit conflicting on t

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-23 Thread Chang
Hi, Could you please why a **reneged** newly acked TSN doesn't qualify the highest_new_tsn? What's the wrongs of doing that? I've been thinking a few scenarios, but I couldn't figure out what's wrong with that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-23 Thread Chang
On 11/22/2013 11:48 PM, Vlad Yasevich wrote: On 11/22/2013 02:24 PM, Chang wrote: On 11/22/2013 03:27 PM, Vlad Yasevich wrote: On 11/22/2013 02:49 AM, Chang Xiangzhong wrote: tsn_gap_acked is an important state flag in chunk, which indicates if the chunk has been acked in gap reports before.

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Vlad Yasevich
On 11/22/2013 02:24 PM, Chang wrote: > > On 11/22/2013 03:27 PM, Vlad Yasevich wrote: >> On 11/22/2013 02:49 AM, Chang Xiangzhong wrote: >>> tsn_gap_acked is an important state flag in chunk, which indicates if >>> the >>> chunk has been acked in gap reports before. >> Actually, this bit indicates

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Chang
On 11/22/2013 03:27 PM, Vlad Yasevich wrote: On 11/22/2013 02:49 AM, Chang Xiangzhong wrote: tsn_gap_acked is an important state flag in chunk, which indicates if the chunk has been acked in gap reports before. Actually, this bit indicates simply that the chunk has been acked. It doesn't stat

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Vlad Yasevich
On 11/22/2013 02:49 AM, Chang Xiangzhong wrote: > tsn_gap_acked is an important state flag in chunk, which indicates if the > chunk has been acked in gap reports before. Actually, this bit indicates simply that the chunk has been acked. It doesn't state whether it's been acked in a gap report or

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Neil Horman
On Fri, Nov 22, 2013 at 08:49:49AM +0100, Chang Xiangzhong wrote: > tsn_gap_acked is an important state flag in chunk, which indicates if the > chunk has been acked in gap reports before. SFR-CACC algorithm depends on this > variable. So set this at the end of each iteration, otherwise the SFR-CACC