Re: [PATCH] net: Add MOXA ART SoCs ethernet driver

2013-07-26 Thread Jonas Jensen
Hi Florian, Thanks for your help on IRC with this. I think most of the issues you pointed out should be fixed. Comments on still unresolved below: On 22 July 2013 13:09, Florian Fainelli wrote: >> +++ b/Documentation/devicetree/bindings/net/moxa,moxart-mac.txt >> @@ -0,0 +1,25 @@ >> +MOXA ART Et

Re: [PATCH] net: Add MOXA ART SoCs ethernet driver

2013-07-22 Thread Florian Fainelli
Hello Jonas, A bunch of comments inline. 2013/7/18 Jonas Jensen : > The MOXA UC-711X hardware(s) has an ethernet controller that seem to be > developed internally. The IC used is "RTL8201CP". > > Since there is no public documentation, this driver is mostly the one > published by MOXA that has be

Re: [PATCH] net: Add MOXA ART SoCs ethernet driver

2013-07-20 Thread Jonas Jensen
I think this driver may have a bug. After some time running ping successfully, the message "no TX space for packet" is printed resulting in 100% packet loss. The message is printed from .ndo_start_xmit and I think it may be because of how priv->tx_desc_now is now set up in moxart_mac_setup_desc_r