Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

2019-09-10 Thread Saeed Mahameed
On Tue, 2019-09-10 at 15:38 +, David Laight wrote: > From: Arnd Bergmann > > Sent: 10 September 2019 09:15 > ... > > > I am not sure how this would work, since the format parameters > > > can > > > changes depending on the FW string and the specific traces. > > > > Ah, so the format string com

RE: [PATCH] net/mlx5: reduce stack usage in FW tracer

2019-09-10 Thread David Laight
From: Arnd Bergmann > Sent: 10 September 2019 09:15 ... > > I am not sure how this would work, since the format parameters can > > changes depending on the FW string and the specific traces. > > Ah, so the format string comes from the firmware? I didn't look > at the code in enough detail to under

Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

2019-09-10 Thread Arnd Bergmann
On Mon, Sep 9, 2019 at 11:53 PM Saeed Mahameed wrote: > On Mon, 2019-09-09 at 22:18 +0200, Arnd Bergmann wrote: > > To do this right, a better approach may be to just rely on ftrace, > > storing > > the (pointer to the) format string and the arguments in the buffer > > without > > creating a stri

Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

2019-09-09 Thread Saeed Mahameed
On Mon, 2019-09-09 at 22:18 +0200, Arnd Bergmann wrote: > On Mon, Sep 9, 2019 at 9:39 PM Saeed Mahameed > wrote: > > On Fri, 2019-09-06 at 17:11 +0200, Arnd Bergmann wrote: > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag

Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

2019-09-09 Thread Arnd Bergmann
On Mon, Sep 9, 2019 at 9:39 PM Saeed Mahameed wrote: > On Fri, 2019-09-06 at 17:11 +0200, Arnd Bergmann wrote: > > --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c > > @@ -557,16 +557,16 @@ static void mlx5_tracer_pri

Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

2019-09-09 Thread Saeed Mahameed
On Fri, 2019-09-06 at 17:11 +0200, Arnd Bergmann wrote: > It's generally not ok to put a 512 byte buffer on the stack, as > kernel > stack is a scarce resource: > > drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c:660:13: > error: stack frame size of 1032 bytes in function > 'mlx5_fw_trace