Re: [PATCH] mtd: rawnand: intel: remove broken code

2021-01-04 Thread Miquel Raynal
Hi Martin, Martin Blumenstingl wrote on Mon, 4 Jan 2021 14:13:04 +0100: > Hi Miquel, > > thank you for looking into this > > On Mon, Jan 4, 2021 at 9:48 AM Miquel Raynal > wrote: > [...] > > > nand_set_flash_node(&ebu_host->chip, dev->of_node); > > > - if (!mtd->name) { > > > -

Re: [PATCH] mtd: rawnand: intel: remove broken code

2021-01-04 Thread Martin Blumenstingl
Hi Miquel, thank you for looking into this On Mon, Jan 4, 2021 at 9:48 AM Miquel Raynal wrote: [...] > > nand_set_flash_node(&ebu_host->chip, dev->of_node); > > - if (!mtd->name) { > > - dev_err(ebu_host->dev, "NAND label property is mandatory\n"); > > - return

Re: [PATCH] mtd: rawnand: intel: remove broken code

2021-01-04 Thread Miquel Raynal
Hi Martin, Martin Blumenstingl wrote on Thu, 17 Dec 2020 23:11:48 +0100: > Drop the check for mtd->name as it's executed while the mtd variable is > always NULL. If some MTD name is needed then it should be validated by > the MTD core. > > While here, also drop the NULL assignment to the mtd va