Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt

2015-02-19 Thread Maxime Ripard
On Wed, Feb 18, 2015 at 06:16:17PM +0100, Robert Jarzmik wrote: > >> @@ -1672,7 +1688,8 @@ static int alloc_nand_resource(struct > >> platform_device *pdev) > >>/* initialize all interrupts to be disabled */ > >>disable_int(info, NDSR_MASK); > >> > >> - ret = request_irq(irq, pxa3xx_nan

Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt

2015-02-18 Thread Robert Jarzmik
Maxime Ripard writes: > On Tue, Feb 17, 2015 at 09:06:57PM +0100, Robert Jarzmik wrote: >> Change the handling of the data stage in the driver : don't pump data in >> the top-half interrupt, but rather schedule a thread for non dma cases. >> >> This will enable latencies in the data pumping, esp

Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt

2015-02-18 Thread Robert Jarzmik
Ezequiel Garcia writes: >> +static irqreturn_t pxa3xx_nand_irq_thread(int irq, void *data) >> +{ >> +struct pxa3xx_nand_info *info = data; >> + >> +handle_data_pio(info); >> + >> +info->state = STATE_CMD_DONE; > > Are you sure you need to set the state here? Euh no, I'm not. I made it

Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt

2015-02-18 Thread Ezequiel Garcia
On 02/17/2015 05:06 PM, Robert Jarzmik wrote: > Change the handling of the data stage in the driver : don't pump data in > the top-half interrupt, but rather schedule a thread for non dma cases. > > This will enable latencies in the data pumping, especially if delays are > required. Moreover platf

Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt

2015-02-18 Thread Maxime Ripard
On Tue, Feb 17, 2015 at 09:06:57PM +0100, Robert Jarzmik wrote: > Change the handling of the data stage in the driver : don't pump data in > the top-half interrupt, but rather schedule a thread for non dma cases. > > This will enable latencies in the data pumping, especially if delays are > requir