Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-25 Thread Shawn Lin
在 2016/5/26 11:59, Jaehoon Chung 写道: On 05/26/2016 11:23 AM, Shawn Lin wrote: Hi Jaehoon, On 2016/5/19 21:07, Jaehoon Chung wrote: On 05/19/2016 08:31 PM, Shawn Lin wrote: Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-25 Thread Jaehoon Chung
On 05/26/2016 11:23 AM, Shawn Lin wrote: > Hi Jaehoon, > > On 2016/5/19 21:07, Jaehoon Chung wrote: >> On 05/19/2016 08:31 PM, Shawn Lin wrote: >>> Hi, >>> >>> On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: > Hi > > >

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-25 Thread Shawn Lin
Hi Jaehoon, On 2016/5/19 21:07, Jaehoon Chung wrote: On 05/19/2016 08:31 PM, Shawn Lin wrote: Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin w

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-19 Thread Jaehoon Chung
On 05/19/2016 08:31 PM, Shawn Lin wrote: > Hi, > > On 2016/5/19 1:37, Doug Anderson wrote: >> Hi, >> >> On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: >>> Hi >>> >>> >>> On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: >>>

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-19 Thread Shawn Lin
Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: Could you try this patch to see if you can still find HLE? @@ -2356,12 +2356,22 @@ stati

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-18 Thread Heiko Stuebner
Am Mittwoch, 18. Mai 2016, 10:37:52 schrieb Doug Anderson: > Note: I'd be very curious if your problems get better if you disable > the "grf_force_jtag" bit in the GRF. If you're using the builtin card > detect and you use the boot default of "grf_force_jtag" then your pins > will be unmuxed behin

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-18 Thread Doug Anderson
Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: > Hi > > > On 2016-5-18 12:12, Doug Anderson wrote: >> >> Hi, >> >> On Tue, May 17, 2016 at 6:59 PM, Shawn Lin >> wrote: >>> >>> Could you try this patch to see if you can still find HLE? >>> >>> @@ -2356,12 +2356,22 @@ static void dw_mci_cmd

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-18 Thread Shawn Lin
Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: Could you try this patch to see if you can still find HLE? @@ -2356,12 +2356,22 @@ static void dw_mci_cmd_interrupt(struct dw_mci *host, u32 status) static void dw_mci_handle_cd(struct dw_mci

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-17 Thread Doug Anderson
Hi, On Tue, May 17, 2016 at 7:08 PM, Jaehoon Chung wrote: > On 05/18/2016 09:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >>> Jaehoon, >>> >>> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung >>> wrote: Dear Doug, I'm consider

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-17 Thread Doug Anderson
Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: > Could you try this patch to see if you can still find HLE? > > @@ -2356,12 +2356,22 @@ static void dw_mci_cmd_interrupt(struct dw_mci > *host, u32 status) > static void dw_mci_handle_cd(struct dw_mci *host) > { > int i; > + i

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-17 Thread Jaehoon Chung
On 05/18/2016 09:47 AM, Doug Anderson wrote: > Jaehoon, > > On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung >> wrote: >>> Dear Doug, >>> >>> I'm considering to control HLE error..So holding this patch. >>> If this is absolut

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-17 Thread Shawn Lin
Hi Doug, On 2016-5-18 8:47, Doug Anderson wrote: Jaehoon, On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: Jaehoon, On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: Dear Doug, I'm considering to control HLE error..So holding this patch. If this is absolutely necessary patch, let

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2016-05-17 Thread Doug Anderson
Jaehoon, On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: > Jaehoon, > > On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: >> Dear Doug, >> >> I'm considering to control HLE error..So holding this patch. >> If this is absolutely necessary patch, let me know, plz. >> >> Best Regards, >>

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2015-03-30 Thread Doug Anderson
Jaehoon, On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: > Dear Doug, > > I'm considering to control HLE error..So holding this patch. > If this is absolutely necessary patch, let me know, plz. > > Best Regards, > Jaehoon Chung Sounds OK. I have certainly applied this locally and the driv

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2015-03-29 Thread Jaehoon Chung
Dear Doug, I'm considering to control HLE error..So holding this patch. If this is absolutely necessary patch, let me know, plz. Best Regards, Jaehoon Chung On 03/16/2015 02:56 PM, Jaehoon Chung wrote: > Hi, Doug. > > On 03/14/2015 05:27 AM, Doug Anderson wrote: >> Hi, >> >> On Fri, Mar 13, 201

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2015-03-15 Thread Jaehoon Chung
Hi, Doug. On 03/14/2015 05:27 AM, Doug Anderson wrote: > Hi, > > On Fri, Mar 13, 2015 at 4:30 AM, Jaehoon Chung wrote: >> Hi, Doug. >> >> On 03/11/2015 12:48 AM, Doug Anderson wrote: >>> The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but >>> nothing in the interrupt handler a

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2015-03-13 Thread Doug Anderson
Hi, On Fri, Mar 13, 2015 at 4:30 AM, Jaehoon Chung wrote: > Hi, Doug. > > On 03/11/2015 12:48 AM, Doug Anderson wrote: >> The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but >> nothing in the interrupt handler actually handles them and ACKs them. >> That means that if we ever g

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

2015-03-13 Thread Jaehoon Chung
Hi, Doug. On 03/11/2015 12:48 AM, Doug Anderson wrote: > The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but > nothing in the interrupt handler actually handles them and ACKs them. > That means that if we ever get an HLE error we'll just keep getting > interrupts and we'll wedge