Re: [PATCH] mm: vmscan: do not share cgroup iteration between reclaimers

2019-08-14 Thread Michal Hocko
On Tue 13-08-19 13:12:37, Johannes Weiner wrote: > On Tue, Aug 13, 2019 at 03:29:38PM +0200, Michal Hocko wrote: > > On Mon 12-08-19 15:23:16, Johannes Weiner wrote: [...] > > > This change completely eliminates the OOM kills on our service, while > > > showing no signs of overreclaim - no increase

Re: [PATCH] mm: vmscan: do not share cgroup iteration between reclaimers

2019-08-13 Thread Johannes Weiner
On Tue, Aug 13, 2019 at 08:59:38AM -0700, Yang Shi wrote: > On Tue, Aug 13, 2019 at 6:29 AM Michal Hocko wrote: > > > > On Mon 12-08-19 15:23:16, Johannes Weiner wrote: > > > One of our services observed a high rate of cgroup OOM kills in the > > > presence of large amounts of clean cache. Debuggi

Re: [PATCH] mm: vmscan: do not share cgroup iteration between reclaimers

2019-08-13 Thread Johannes Weiner
On Tue, Aug 13, 2019 at 03:29:38PM +0200, Michal Hocko wrote: > On Mon 12-08-19 15:23:16, Johannes Weiner wrote: > > One of our services observed a high rate of cgroup OOM kills in the > > presence of large amounts of clean cache. Debugging showed that the > > culprit is the shared cgroup iteration

Re: [PATCH] mm: vmscan: do not share cgroup iteration between reclaimers

2019-08-13 Thread Yang Shi
On Tue, Aug 13, 2019 at 6:29 AM Michal Hocko wrote: > > On Mon 12-08-19 15:23:16, Johannes Weiner wrote: > > One of our services observed a high rate of cgroup OOM kills in the > > presence of large amounts of clean cache. Debugging showed that the > > culprit is the shared cgroup iteration in pag

Re: [PATCH] mm: vmscan: do not share cgroup iteration between reclaimers

2019-08-13 Thread Michal Hocko
On Mon 12-08-19 15:23:16, Johannes Weiner wrote: > One of our services observed a high rate of cgroup OOM kills in the > presence of large amounts of clean cache. Debugging showed that the > culprit is the shared cgroup iteration in page reclaim. > > Under high allocation concurrency, multiple thr

Re: [PATCH] mm: vmscan: do not share cgroup iteration between reclaimers

2019-08-12 Thread Johannes Weiner
On Mon, Aug 12, 2019 at 09:07:27PM +, Roman Gushchin wrote: > On Mon, Aug 12, 2019 at 03:23:16PM -0400, Johannes Weiner wrote: > > @@ -2679,7 +2675,7 @@ static bool shrink_node(pg_data_t *pgdat, struct > > scan_control *sc) > > nr_reclaimed = sc->nr_reclaimed; > > nr_sc

Re: [PATCH] mm: vmscan: do not share cgroup iteration between reclaimers

2019-08-12 Thread Roman Gushchin
On Mon, Aug 12, 2019 at 03:23:16PM -0400, Johannes Weiner wrote: > One of our services observed a high rate of cgroup OOM kills in the > presence of large amounts of clean cache. Debugging showed that the > culprit is the shared cgroup iteration in page reclaim. > > Under high allocation concurren