Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-26 Thread Wei Yang
On Mon, Nov 26, 2018 at 05:42:28PM -0800, Wengang Wang wrote: > > >On 2018/11/26 16:36, Wei Yang wrote: >> On Mon, Nov 26, 2018 at 08:57:54AM -0800, Wengang Wang wrote: >> > >> > On 2018/11/25 17:59, Wei Yang wrote: >> > > On Tue, Nov 20, 2018 at 10:58 AM zhong jiang >> > > wrote: >> > > > On 20

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-26 Thread Wengang Wang
On 2018/11/26 16:36, Wei Yang wrote: On Mon, Nov 26, 2018 at 08:57:54AM -0800, Wengang Wang wrote: On 2018/11/25 17:59, Wei Yang wrote: On Tue, Nov 20, 2018 at 10:58 AM zhong jiang wrote: On 2018/11/17 9:33, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long as

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-26 Thread Wei Yang
On Mon, Nov 26, 2018 at 08:57:54AM -0800, Wengang Wang wrote: > > >On 2018/11/25 17:59, Wei Yang wrote: >> On Tue, Nov 20, 2018 at 10:58 AM zhong jiang wrote: >> > On 2018/11/17 9:33, Wengang Wang wrote: >> > > The this_cpu_cmpxchg makes the do-while loop pass as long as the >> > > s->cpu_slab->pa

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-26 Thread Wengang Wang
On 2018/11/25 17:59, Wei Yang wrote: On Tue, Nov 20, 2018 at 10:58 AM zhong jiang wrote: On 2018/11/17 9:33, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long as the s->cpu_slab->partial as the same value. It doesn't care what happened to that slab. Interrupt is

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-25 Thread Wei Yang
On Tue, Nov 20, 2018 at 10:58 AM zhong jiang wrote: > > On 2018/11/17 9:33, Wengang Wang wrote: > > The this_cpu_cmpxchg makes the do-while loop pass as long as the > > s->cpu_slab->partial as the same value. It doesn't care what happened to > > that slab. Interrupt is not disabled, and new alloc/

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-21 Thread kbuild test robot
Hi Wengang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-21 Thread Wei Yang
On Tue, Nov 20, 2018 at 07:18:13PM -0800, Wengang Wang wrote: >Hi Wei, > >I think you will receive my reply to Zhong, But I am copying my comments for >that patch here (again): > >Copy starts ==> > >I am not sure if the patch you mentioned intended to fix the problem here. >With that patch the nega

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-20 Thread Wengang Wang
Hi Wei, I think you will receive my reply to Zhong, But I am copying my comments for that patch here (again): Copy starts ==> I am not sure if the patch you mentioned intended to fix the problem here. With that patch the negative page->pobjects would become a large positive value, it will wi

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-20 Thread Wei Yang
On Tue, Nov 20, 2018 at 09:58:58AM -0800, Wengang Wang wrote: >Hi Wei, > > >On 2018/11/17 17:02, Wei Yang wrote: >> On Fri, Nov 16, 2018 at 05:33:35PM -0800, Wengang Wang wrote: >> > The this_cpu_cmpxchg makes the do-while loop pass as long as the >> > s->cpu_slab->partial as the same value. It doe

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-20 Thread Wengang Wang
Hi Zhong, On 2018/11/19 18:18, zhong jiang wrote: On 2018/11/17 9:33, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long as the s->cpu_slab->partial as the same value. It doesn't care what happened to that slab. Interrupt is not disabled, and new alloc/free can happe

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-20 Thread Wengang Wang
Hi Wei, On 2018/11/17 17:02, Wei Yang wrote: On Fri, Nov 16, 2018 at 05:33:35PM -0800, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long as the s->cpu_slab->partial as the same value. It doesn't care what happened to that slab. Interrupt is not disabled, and new all

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-19 Thread kbuild test robot
Hi Wengang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc3 next-20181119] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-19 Thread zhong jiang
On 2018/11/17 9:33, Wengang Wang wrote: > The this_cpu_cmpxchg makes the do-while loop pass as long as the > s->cpu_slab->partial as the same value. It doesn't care what happened to > that slab. Interrupt is not disabled, and new alloc/free can happen in the > interrupt handlers. Theoretically, aft

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-17 Thread Wei Yang
On Fri, Nov 16, 2018 at 05:33:35PM -0800, Wengang Wang wrote: >The this_cpu_cmpxchg makes the do-while loop pass as long as the >s->cpu_slab->partial as the same value. It doesn't care what happened to >that slab. Interrupt is not disabled, and new alloc/free can happen in the Well, I seems to und

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-16 Thread Wei Yang
On Fri, Nov 16, 2018 at 05:33:35PM -0800, Wengang Wang wrote: >The this_cpu_cmpxchg makes the do-while loop pass as long as the >s->cpu_slab->partial as the same value. It doesn't care what happened to >that slab. Interrupt is not disabled, and new alloc/free can happen in the >interrupt handlers.