Re: [PATCH] mm: fix page cache convergence regression

2019-06-24 Thread Linus Torvalds
On Mon, Jun 24, 2019 at 11:19 PM Johannes Weiner wrote: > > Hey, it's three weeks later and we're about to miss 5.2. > > This sucks, Matthew. Yes. And I do think that having a real gfp field there would be better than the very odd xa_flags that is *marked* as being gfp_t, but isn't really a gfp_

Re: [PATCH] mm: fix page cache convergence regression

2019-06-24 Thread Johannes Weiner
On Thu, May 30, 2019 at 10:13:56AM -0700, Matthew Wilcox wrote: > On Thu, May 30, 2019 at 12:15:48PM -0400, Johannes Weiner wrote: > > Are there any objections or feedback on the proposed fix below? This > > is kind of a serious regression. > > I'll drop it into the xarray tree for merging in a we

Re: [PATCH] mm: fix page cache convergence regression

2019-05-30 Thread Johannes Weiner
On Thu, May 30, 2019 at 10:13:56AM -0700, Matthew Wilcox wrote: > On Thu, May 30, 2019 at 12:15:48PM -0400, Johannes Weiner wrote: > > Are there any objections or feedback on the proposed fix below? This > > is kind of a serious regression. > > I'll drop it into the xarray tree for merging in a we

Re: [PATCH] mm: fix page cache convergence regression

2019-05-30 Thread Matthew Wilcox
On Thu, May 30, 2019 at 12:15:48PM -0400, Johannes Weiner wrote: > Are there any objections or feedback on the proposed fix below? This > is kind of a serious regression. I'll drop it into the xarray tree for merging in a week, if that's ok with you?

Re: [PATCH] mm: fix page cache convergence regression

2019-05-30 Thread Johannes Weiner
Are there any objections or feedback on the proposed fix below? This is kind of a serious regression. On Fri, May 24, 2019 at 01:39:00PM -0400, Johannes Weiner wrote: > From 63a0dbc571ff38f7c072c62d6bc28192debe37ac Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Fri, 24 May 2019 10:12:46

Re: [PATCH] mm: fix page cache convergence regression

2019-05-24 Thread Shakeel Butt
On Fri, May 24, 2019 at 10:41 AM Johannes Weiner wrote: > > On Fri, May 24, 2019 at 09:04:17AM -0700, Matthew Wilcox wrote: > > On Fri, May 24, 2019 at 11:31:48AM -0400, Johannes Weiner wrote: > > > diff --git a/include/linux/xarray.h b/include/linux/xarray.h > > > index 0e01e6129145..cbbf76e4c973

Re: [PATCH] mm: fix page cache convergence regression

2019-05-24 Thread Johannes Weiner
On Fri, May 24, 2019 at 09:04:17AM -0700, Matthew Wilcox wrote: > On Fri, May 24, 2019 at 11:31:48AM -0400, Johannes Weiner wrote: > > diff --git a/include/linux/xarray.h b/include/linux/xarray.h > > index 0e01e6129145..cbbf76e4c973 100644 > > --- a/include/linux/xarray.h > > +++ b/include/linux/xa

Re: [PATCH] mm: fix page cache convergence regression

2019-05-24 Thread Matthew Wilcox
On Fri, May 24, 2019 at 11:31:48AM -0400, Johannes Weiner wrote: > diff --git a/include/linux/xarray.h b/include/linux/xarray.h > index 0e01e6129145..cbbf76e4c973 100644 > --- a/include/linux/xarray.h > +++ b/include/linux/xarray.h > @@ -292,6 +292,7 @@ struct xarray { > spinlock_t xa_lo