Re: [PATCH] mm: fix NULL checking in dma_pool_create()

On 11/5/12 4:26 PM, Andrew Morton wrote: > > OK, so it seems that those drivers have never been tested on a > CONFIG_NUMA kernel. whee. > > So we have a large amount of code here which ostensibly supports > dev==NULL but which has not been well tested. Take a look at > dma_alloc_coherent(), dma

Re: [PATCH] mm: fix NULL checking in dma_pool_create()

On Mon, 05 Nov 2012 15:50:32 -0500 Xi Wang wrote: > On 11/5/12 3:37 PM, Andrew Morton wrote: > > > > Well, the dma_pool_create() kerneldoc does not describe dev==NULL to be > > acceptable usage and given the lack of oops reports, we can assume that > > no code is calling this function with dev==

Re: [PATCH] mm: fix NULL checking in dma_pool_create()

On 11/5/12 3:37 PM, Andrew Morton wrote: > > Well, the dma_pool_create() kerneldoc does not describe dev==NULL to be > acceptable usage and given the lack of oops reports, we can assume that > no code is calling this function with dev==NULL. > > So I think we can just remove the code which handle

Re: [PATCH] mm: fix NULL checking in dma_pool_create()

On Mon, 5 Nov 2012 01:46:36 -0500 Xi Wang wrote: > First, `dev' is dereferenced in dev_to_node(dev), suggesting that it > must be non-null. Later `dev' is checked against NULL, suggesting > the opposite. This patch adds a NULL check before its use. > > ... > > @@ -159,7 +160,9 @@ struct dma_p