Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Peter Zijlstra
On Fri, 2007-10-12 at 10:45 -0700, Suleiman Souhlal wrote: > On Oct 12, 2007, at 7:58 AM, Peter Zijlstra wrote: > > > On Fri, 2007-10-12 at 07:53 -0700, Arjan van de Ven wrote: > >> On Fri, 12 Oct 2007 12:50:22 +0200 > > The pages will still be read-only due to dirty tracking, so the > >

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Arjan van de Ven
On Fri, 12 Oct 2007 10:45:17 -0700 Suleiman Souhlal <[EMAIL PROTECTED]> wrote: > > On Oct 12, 2007, at 7:58 AM, Peter Zijlstra wrote: > > > On Fri, 2007-10-12 at 07:53 -0700, Arjan van de Ven wrote: > >> On Fri, 12 Oct 2007 12:50:22 +0200 > > The pages will still be read-only due to dirty tr

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Suleiman Souhlal
On Oct 12, 2007, at 7:58 AM, Peter Zijlstra wrote: On Fri, 2007-10-12 at 07:53 -0700, Arjan van de Ven wrote: On Fri, 12 Oct 2007 12:50:22 +0200 The pages will still be read-only due to dirty tracking, so the first write will still do page_mkwrite(). Which can SIGBUS, no? Sure, but that i

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Peter Zijlstra
On Fri, 2007-10-12 at 07:53 -0700, Arjan van de Ven wrote: > On Fri, 12 Oct 2007 12:50:22 +0200 > > > > The pages will still be read-only due to dirty tracking, so the > > > > first write will still do page_mkwrite(). > > > > > > Which can SIGBUS, no? > > > > Sure, but that is no different than a

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Arjan van de Ven
On Fri, 12 Oct 2007 12:50:22 +0200 > > > The pages will still be read-only due to dirty tracking, so the > > > first write will still do page_mkwrite(). > > > > Which can SIGBUS, no? > > Sure, but that is no different than any other mmap'ed write. I'm not > seeing how an mlocked region is special

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Nick Piggin
On Friday 12 October 2007 20:50, Peter Zijlstra wrote: > On Fri, 2007-10-12 at 04:14 +1000, Nick Piggin wrote: > > On Friday 12 October 2007 20:37, Peter Zijlstra wrote: > > > The pages will still be read-only due to dirty tracking, so the first > > > write will still do page_mkwrite(). > > > > Wh

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Peter Zijlstra
On Fri, 2007-10-12 at 04:14 +1000, Nick Piggin wrote: > On Friday 12 October 2007 20:37, Peter Zijlstra wrote: > > On Fri, 2007-10-12 at 02:57 +1000, Nick Piggin wrote: > > > On Friday 12 October 2007 19:03, Peter Zijlstra wrote: > > > > Subject: mm: avoid dirtying shared mappings on mlock > > > >

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Nick Piggin
On Friday 12 October 2007 20:37, Peter Zijlstra wrote: > On Fri, 2007-10-12 at 02:57 +1000, Nick Piggin wrote: > > On Friday 12 October 2007 19:03, Peter Zijlstra wrote: > > > Subject: mm: avoid dirtying shared mappings on mlock > > > > > > Suleiman noticed that shared mappings get dirtied when mlo

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Peter Zijlstra
On Fri, 2007-10-12 at 02:57 +1000, Nick Piggin wrote: > On Friday 12 October 2007 19:03, Peter Zijlstra wrote: > > Subject: mm: avoid dirtying shared mappings on mlock > > > > Suleiman noticed that shared mappings get dirtied when mlocked. > > Avoid this by teaching make_pages_present about this ca

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Nick Piggin
On Friday 12 October 2007 02:57, Nick Piggin wrote: > On Friday 12 October 2007 19:03, Peter Zijlstra wrote: > > Subject: mm: avoid dirtying shared mappings on mlock > > > > Suleiman noticed that shared mappings get dirtied when mlocked. > > Avoid this by teaching make_pages_present about this case

Re: [PATCH] mm: avoid dirtying shared mappings on mlock

2007-10-12 Thread Nick Piggin
On Friday 12 October 2007 19:03, Peter Zijlstra wrote: > Subject: mm: avoid dirtying shared mappings on mlock > > Suleiman noticed that shared mappings get dirtied when mlocked. > Avoid this by teaching make_pages_present about this case. > > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > Acke