Re: [PATCH] mm: Improve documentation of page_order

2014-01-19 Thread Minchan Kim
On Fri, Jan 17, 2014 at 02:32:21PM +, Mel Gorman wrote: > Developers occasionally try and optimise PFN scanners by using page_order > but miss that in general it requires zone->lock. This has happened twice for > compaction.c and rejected both times. This patch clarifies the documentation > of

Re: [PATCH] mm: Improve documentation of page_order

2014-01-17 Thread Mel Gorman
On Fri, Jan 17, 2014 at 10:53:50AM -0800, Laura Abbott wrote: > On 1/17/2014 6:32 AM, Mel Gorman wrote: > >Developers occasionally try and optimise PFN scanners by using page_order > >but miss that in general it requires zone->lock. This has happened twice for > >compaction.c and rejected both time

Re: [PATCH] mm: Improve documentation of page_order

2014-01-17 Thread Laura Abbott
On 1/17/2014 6:32 AM, Mel Gorman wrote: Developers occasionally try and optimise PFN scanners by using page_order but miss that in general it requires zone->lock. This has happened twice for compaction.c and rejected both times. This patch clarifies the documentation of page_order and adds a not

Re: [PATCH] mm: Improve documentation of page_order

2014-01-17 Thread Rafael Aquini
On Fri, Jan 17, 2014 at 02:32:21PM +, Mel Gorman wrote: > Developers occasionally try and optimise PFN scanners by using page_order > but miss that in general it requires zone->lock. This has happened twice for > compaction.c and rejected both times. This patch clarifies the documentation > of