Re: [PATCH] mm/page_alloc: cleanup __alloc_pages_direct_compact()

2019-08-19 Thread Pengfei Li
On Mon, Aug 19, 2019 at 9:50 PM Vlastimil Babka wrote: > > On 8/17/19 12:51 PM, Pengfei Li wrote: > > This patch cleans up the if(page). > > > > No functional change. > > > > Signed-off-by: Pengfei Li > > I don't see much benefit here. The indentation wasn't that bad that it > had to be reduced u

Re: [PATCH] mm/page_alloc: cleanup __alloc_pages_direct_compact()

2019-08-19 Thread Vlastimil Babka
On 8/17/19 12:51 PM, Pengfei Li wrote: > This patch cleans up the if(page). > > No functional change. > > Signed-off-by: Pengfei Li I don't see much benefit here. The indentation wasn't that bad that it had to be reduced using goto. But the patch is not incorrect so I'm not NACKing. > --- > m