Re: [PATCH] mm/dmapool.c: add WARN_ON() in dma_pool_destroy

2020-07-31 Thread Matthew Wilcox
On Fri, Jul 31, 2020 at 01:32:15PM -0700, Andrew Morton wrote: > On Fri, 31 Jul 2020 03:38:58 +0100 Matthew Wilcox wrote: > > > On Fri, Jul 31, 2020 at 10:39:39AM +0800, qiang.zh...@windriver.com wrote: > > > The pool is being destroyed, all page which in the pool, > > > should be free. if some p

Re: [PATCH] mm/dmapool.c: add WARN_ON() in dma_pool_destroy

2020-07-31 Thread Andrew Morton
On Fri, 31 Jul 2020 03:38:58 +0100 Matthew Wilcox wrote: > On Fri, Jul 31, 2020 at 10:39:39AM +0800, qiang.zh...@windriver.com wrote: > > The pool is being destroyed, all page which in the pool, > > should be free. if some page is still be use by somebody, > > we should not just output error logs

Re: [PATCH] mm/dmapool.c: add WARN_ON() in dma_pool_destroy

2020-07-30 Thread Matthew Wilcox
On Fri, Jul 31, 2020 at 10:39:39AM +0800, qiang.zh...@windriver.com wrote: > The pool is being destroyed, all page which in the pool, > should be free. if some page is still be use by somebody, > we should not just output error logs, also should also add > a warning message. There's already a warn