Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-25 Thread Michal Hocko
On Tue 24-11-15 14:57:10, Johannes Weiner wrote: > On Tue, Nov 24, 2015 at 06:02:39PM +0100, Michal Hocko wrote: > > On Tue 24-11-15 11:26:04, Johannes Weiner wrote: > > > On Tue, Nov 24, 2015 at 10:47:09AM +0100, Michal Hocko wrote: > > > > Besides that there is no other reliable warning that we a

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-24 Thread Johannes Weiner
On Tue, Nov 24, 2015 at 06:02:39PM +0100, Michal Hocko wrote: > On Tue 24-11-15 11:26:04, Johannes Weiner wrote: > > On Tue, Nov 24, 2015 at 10:47:09AM +0100, Michal Hocko wrote: > > > Besides that there is no other reliable warning that we are getting > > > _really_ short on memory unlike when the

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-24 Thread Michal Hocko
On Tue 24-11-15 11:26:04, Johannes Weiner wrote: > On Tue, Nov 24, 2015 at 10:47:09AM +0100, Michal Hocko wrote: > > Besides that there is no other reliable warning that we are getting > > _really_ short on memory unlike when the allocation failure is > > allowed. OOM killer report might be missing

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-24 Thread Johannes Weiner
On Tue, Nov 24, 2015 at 10:47:09AM +0100, Michal Hocko wrote: > Besides that there is no other reliable warning that we are getting > _really_ short on memory unlike when the allocation failure is > allowed. OOM killer report might be missing because there was no actual > killing happening. This i

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-24 Thread Michal Hocko
On Mon 23-11-15 13:26:49, David Rientjes wrote: > On Mon, 23 Nov 2015, Michal Hocko wrote: [...] > > I am not sure I follow you here. The point of the warning is to warn > > when the oom killer is disbaled (out_of_memory returns false) _and_ the > > request is __GFP_NOFAIL because we simply cannot

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-23 Thread David Rientjes
On Mon, 23 Nov 2015, Michal Hocko wrote: > > >>>diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > >>>index 8034909faad2..d30bce9d7ac8 100644 > > >>>--- a/mm/page_alloc.c > > >>>+++ b/mm/page_alloc.c > > >>>@@ -2766,8 +2766,16 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned > > >>>int order, >

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-23 Thread Michal Hocko
On Mon 23-11-15 10:43:42, Vlastimil Babka wrote: > On 11/23/2015 10:29 AM, Michal Hocko wrote: > >On Sun 22-11-15 13:55:31, Vlastimil Babka wrote: > >>On 11.11.2015 14:48, mho...@kernel.org wrote: > >>> mm/page_alloc.c | 10 +- > >>> 1 file changed, 9 insertions(+), 1 deletion(-) > >>> > >

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-23 Thread Vlastimil Babka
On 11/23/2015 10:29 AM, Michal Hocko wrote: On Sun 22-11-15 13:55:31, Vlastimil Babka wrote: On 11.11.2015 14:48, mho...@kernel.org wrote: mm/page_alloc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 8034909faad2..d30bc

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-23 Thread Michal Hocko
On Sun 22-11-15 13:55:31, Vlastimil Babka wrote: > On 11.11.2015 14:48, mho...@kernel.org wrote: > > mm/page_alloc.c | 10 +- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 8034909faad2..d30bce9d7ac8 100644 > > --- a/mm/

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-22 Thread Vlastimil Babka
On 11.11.2015 14:48, mho...@kernel.org wrote: > mm/page_alloc.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 8034909faad2..d30bce9d7ac8 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2766,8 +2766,16 @@ _

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-12 Thread Michal Hocko
On Wed 11-11-15 10:54:46, Johannes Weiner wrote: > On Wed, Nov 11, 2015 at 02:48:17PM +0100, mho...@kernel.org wrote: > > From: Michal Hocko > > > > __GFP_NOFAIL is a big hammer used to ensure that the allocation > > request can never fail. This is a strong requirement and as such > > it also des

Re: [PATCH] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves

2015-11-11 Thread Johannes Weiner
On Wed, Nov 11, 2015 at 02:48:17PM +0100, mho...@kernel.org wrote: > From: Michal Hocko > > __GFP_NOFAIL is a big hammer used to ensure that the allocation > request can never fail. This is a strong requirement and as such > it also deserves a special treatment when the system is OOM. The > prima