Re: [PATCH] mfd: max77686: fix support for devices without irq specified

2014-08-08 Thread Javier Martinez Canillas
On 08/08/2014 02:24 PM, Bartlomiej Zolnierkiewicz wrote: > > It seems that Daniel Drake has already fixed ODROID dtsi with: > > [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34191.html > > and > > [PATCH 2/2] ARM:

Re: [PATCH] mfd: max77686: fix support for devices without irq specified

2014-08-08 Thread Bartlomiej Zolnierkiewicz
Hi Javier, On Friday, August 08, 2014 12:58:50 PM Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/08/2014 12:54 PM, Krzysztof Kozlowski wrote: > >> >> > >> >> Not sufficient. You have to also fix RTC driver (OOPS from Trats2 > >> >> attached). Also consider adding checks for (max77

Re: [PATCH] mfd: max77686: fix support for devices without irq specified

2014-08-08 Thread Javier Martinez Canillas
Hello Krzysztof, On 08/08/2014 12:54 PM, Krzysztof Kozlowski wrote: >> >> >> >> Not sufficient. You have to also fix RTC driver (OOPS from Trats2 >> >> attached). Also consider adding checks for (max77686->irq) to the >> >> suspend and resume. >> >> >> > >> > Right, the max77686 RTC driver assu

Re: [PATCH] mfd: max77686: fix support for devices without irq specified

2014-08-08 Thread Krzysztof Kozlowski
On piÄ…, 2014-08-08 at 12:09 +0200, Javier Martinez Canillas wrote: > Hello, > > On 08/08/2014 10:58 AM, Javier Martinez Canillas wrote: > > > >> > >> Not sufficient. You have to also fix RTC driver (OOPS from Trats2 > >> attached). Also consider adding checks for (max77686->irq) to the > >> sus

Re: [PATCH] mfd: max77686: fix support for devices without irq specified

2014-08-08 Thread Javier Martinez Canillas
Hello, On 08/08/2014 10:58 AM, Javier Martinez Canillas wrote: > >> >> Not sufficient. You have to also fix RTC driver (OOPS from Trats2 >> attached). Also consider adding checks for (max77686->irq) to the >> suspend and resume. >> > > Right, the max77686 RTC driver assumes that an IRQ domain

Re: [PATCH] mfd: max77686: fix support for devices without irq specified

2014-08-08 Thread Javier Martinez Canillas
Hello Krzysztof and Bartlomiej, On 08/08/2014 09:59 AM, Krzysztof Kozlowski wrote: > On czw, 2014-08-07 at 18:09 +0200, Bartlomiej Zolnierkiewicz wrote: >> Before commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq") >> max77686_irq_init() return value was never checked so devices witho

Re: [PATCH] mfd: max77686: fix support for devices without irq specified

2014-08-08 Thread Krzysztof Kozlowski
On czw, 2014-08-07 at 18:09 +0200, Bartlomiej Zolnierkiewicz wrote: > Before commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq") > max77686_irq_init() return value was never checked so devices without > irq specified (like Hardkernel's Exynos4412 based ODROID-U3 board) > worked fine ev