Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-24 Thread Bjorn Andersson
On Wed 18 Feb 18:29 PST 2015, Stephen Boyd wrote: > On 02/18/15 13:08, Bjorn Andersson wrote: > > On Wed, Feb 18, 2015 at 12:28 PM, Stephen Boyd wrote: After taking a deeper look at this I've come to the following conclusion: We can save 2100 bytes of data by spreading out the magic numbers fro

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-18 Thread Stephen Boyd
On 02/18/15 13:08, Bjorn Andersson wrote: > On Wed, Feb 18, 2015 at 12:28 PM, Stephen Boyd wrote: >> >> MFD name matching isn't required. All we need to do is have a regulators >> node and put a compatible = "qcom,rpm-msm-regulators" in there. Then >> of_platform_populate() does most of the wo

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-18 Thread Bjorn Andersson
On Wed, Feb 18, 2015 at 12:28 PM, Stephen Boyd wrote: > On 02/18/15 10:37, Bjorn Andersson wrote: >> On Tue, Feb 17, 2015 at 6:52 PM, Stephen Boyd wrote: >>> The main benefit I can think of is we cut down on runtime memory bloat. >>> >>> (gdb) p sizeof(struct platform_device) >>> $1 = 624 >>> >>>

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-18 Thread Stephen Boyd
On 02/18/15 10:37, Bjorn Andersson wrote: > On Tue, Feb 17, 2015 at 6:52 PM, Stephen Boyd wrote: >> The main benefit I can think of is we cut down on runtime memory bloat. >> >> (gdb) p sizeof(struct platform_device) >> $1 = 624 >> >> Multiply that by 20 regulators and you get 624 * 20 = 12480 byt

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-18 Thread Bjorn Andersson
On Tue, Feb 17, 2015 at 6:52 PM, Stephen Boyd wrote: > On 02/17/15 13:48, Bjorn Andersson wrote: >> On Fri, Feb 13, 2015 at 2:13 PM, Andy Gross wrote: >>> On Thu, Jan 29, 2015 at 05:51:06PM -0800, Bjorn Andersson wrote: Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings.

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-17 Thread Stephen Boyd
On 02/17/15 13:48, Bjorn Andersson wrote: > On Fri, Feb 13, 2015 at 2:13 PM, Andy Gross wrote: >> On Thu, Jan 29, 2015 at 05:51:06PM -0800, Bjorn Andersson wrote: >>> Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. >>> >>> Signed-off-by: Bjorn Andersson >>> --- >>>

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-17 Thread Bjorn Andersson
On Fri, Feb 13, 2015 at 2:13 PM, Andy Gross wrote: > On Thu, Jan 29, 2015 at 05:51:06PM -0800, Bjorn Andersson wrote: >> Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. >> >> Signed-off-by: Bjorn Andersson >> --- > >> #include >> @@ -66,5 +237,18 @@ frequencies. >>

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-13 Thread Andy Gross
On Thu, Jan 29, 2015 at 05:51:06PM -0800, Bjorn Andersson wrote: > Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. > > Signed-off-by: Bjorn Andersson > --- > #include > @@ -66,5 +237,18 @@ frequencies. > > #address-cells = <1>; > #siz

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-09 Thread Lee Jones
On Tue, 10 Feb 2015, Lee Jones wrote: > On Mon, 09 Feb 2015, Bjorn Andersson wrote: > > > On Thu, Jan 29, 2015 at 5:51 PM, Bjorn Andersson > > wrote: > > > Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. > > > > > > Signed-off-by: Bjorn Andersson > > > --- > > > After d

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-09 Thread Lee Jones
On Mon, 09 Feb 2015, Bjorn Andersson wrote: > On Thu, Jan 29, 2015 at 5:51 PM, Bjorn Andersson > wrote: > > Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. > > > > Signed-off-by: Bjorn Andersson > > --- > > After discussing this back and forth we've concluded that we sho

Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-02-09 Thread Bjorn Andersson
On Thu, Jan 29, 2015 at 5:51 PM, Bjorn Andersson wrote: > Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. > > Signed-off-by: Bjorn Andersson > --- > After discussing this back and forth we've concluded that we should be > future compatible with these bindings, so let's ma