Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-14 Thread Mika Westerberg
On Thu, May 14, 2020 at 01:53:23PM +0100, Richard Hughes wrote: > On Thu, 14 May 2020 at 13:15, Mika Westerberg > wrote: > > > +What:/sys/kernel/security/firmware/bioswe > > Should this still be "firmware_protections" or similar. Plain "firmware" > > sounds again too generic. Maybe

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-14 Thread Richard Hughes
On Thu, 14 May 2020 at 13:15, Mika Westerberg wrote: > > +What:/sys/kernel/security/firmware/bioswe > Should this still be "firmware_protections" or similar. Plain "firmware" > sounds again too generic. Maybe its just me.. It's not always going to be protections provided by the fi

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-14 Thread Mika Westerberg
On Wed, May 13, 2020 at 07:27:50PM +0100, Richard Hughes wrote: > On Wed, 2020-05-13 at 19:25 +0300, Mika Westerberg wrote: > > This may be problematic if there is driver bound to the device and > > accessing the hardware simultaneusly. Although this is just read side > > and I don't think these re

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-13 Thread Richard Hughes
On Wed, 2020-05-13 at 19:25 +0300, Mika Westerberg wrote: > This may be problematic if there is driver bound to the device and > accessing the hardware simultaneusly. Although this is just read side > and I don't think these registers have any side effects when you read > them, so should not be an

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-13 Thread Mika Westerberg
On Wed, May 13, 2020 at 03:13:28PM +0100, Richard Hughes wrote: > On Wed, 13 May 2020 at 10:11, Mika Westerberg > wrote: > > > I can fix up all those, but out of interest how did you "know" the > > > right three digit identifier to use? > > I work for Intel ;-) > > Hah, okay, thanks :) > > > > I

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-13 Thread Richard Hughes
On Wed, 13 May 2020 at 10:11, Mika Westerberg wrote: > > I can fix up all those, but out of interest how did you "know" the > > right three digit identifier to use? > I work for Intel ;-) Hah, okay, thanks :) > > I'm really wondering if drivers/mfd/lpc_ich.c is the right place for > > this kind

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-13 Thread Mika Westerberg
On Wed, May 13, 2020 at 09:48:55AM +0100, Richard Hughes wrote: > On Wed, 13 May 2020 at 08:08, Mika Westerberg > wrote: > > I think this one should contain KernelVersion as well, see > > Documentation/ABI/README. > > Thanks, I'll fix that up. > > > I think you can always include this header wit

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-13 Thread Richard Hughes
On Wed, 13 May 2020 at 08:08, Mika Westerberg wrote: > I think this one should contain KernelVersion as well, see > Documentation/ABI/README. Thanks, I'll fix that up. > I think you can always include this header without #ifs Thanks. > > static struct resource wdt_ich_res[] = { > > @@ -221,6

Re: [PATCH] mfd: Export LPC attributes for the system SPI chip

2020-05-13 Thread Mika Westerberg
Hi Richard, On Tue, May 12, 2020 at 09:42:43PM +0100, Richard Hughes wrote: > Export standard SPI-specific config values from various LPC > controllers. > This allows userspace components such as fwupd to verify the most basic > SPI > protections are set correctly. For instance, checking BIOSWE is