Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed

2015-12-04 Thread Andrew Morton
On Thu, 3 Dec 2015 10:08:26 +0100 Michal Hocko wrote: > So you think a comment would be sufficient? > --- > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 98a1934493af..2e8ee9e5fcb5 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1031,9 +1031,12 @@ static unsigned long shrink_page_list(struc

Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed

2015-12-03 Thread Michal Hocko
On Wed 02-12-15 14:25:03, Andrew Morton wrote: > On Wed, 2 Dec 2015 15:26:18 +0100 Michal Hocko wrote: > > > From: Michal Hocko > > > > Legacy memcg reclaim waits for pages under writeback to prevent from a > > premature oom killer invocation because there was no memcg dirty limit > > throttli

Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed

2015-12-02 Thread Andrew Morton
On Wed, 2 Dec 2015 15:26:18 +0100 Michal Hocko wrote: > From: Michal Hocko > > Legacy memcg reclaim waits for pages under writeback to prevent from a > premature oom killer invocation because there was no memcg dirty limit > throttling implemented back then. > > This heuristic might complicat