Re: [PATCH] megaraid: fix use of delayed work

2012-12-04 Thread Tejun Heo
Hello, again, Xiaotian. On Tue, Dec 04, 2012 at 07:39:39AM -0800, Tejun Heo wrote: > Urgh... what the Didn't see that one coming. I'm gonna push this > to Linus through the workqueue tree. > > Thanks for the fix. It seems like megaraid doesn't have any reason to use delayed_work at all. I

Re: [PATCH] megaraid: fix use of delayed work

2012-12-04 Thread Tejun Heo
On Tue, Dec 04, 2012 at 07:33:54PM +0800, Xiaotian Feng wrote: > megaraid use INIT_WORK to declare a hotplug_work, but cast the hotplug_work > from work_struct to delayed_work and schedule_delayed_work on it. This is > very dangerous, as other part of delayed_work might be kernel memories > alloca