Re: [PATCH] media: qcom: camss: Fix overflows in clock rate calculations

On 10/02/2021 13:29, Vladimir Lypak wrote: > Because of u32 type being used to store pixel clock rate, expression used > to calculate pipeline clocks (pixel_clock * bpp) produces wrong value due > to integer overflow. This patch changes data type used to store, pass and > retrieve pixel_clock from

Re: [PATCH] media: qcom: camss: Fix overflows in clock rate calculations

Hi Vladimir, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v5.11-rc7 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docum

Re: [PATCH] media: qcom: camss: Fix overflows in clock rate calculations

Hey Vladimir, This patch looks good to me, thanks for the submission. Acked-by: Robert Foss On Wed, 10 Feb 2021 at 13:51, Vladimir Lypak wrote: > > Because of u32 type being used to store pixel clock rate, expression used > to calculate pipeline clocks (pixel_clock * bpp) produces wrong value d