Re: [PATCH] media: i2c: imx219: Rewrite tables and implement more modes

2021-01-17 Thread Dave Stevenson
Hi Angelo On Sun, 17 Jan 2021 at 17:33, AngeloGioacchino Del Regno wrote: > > Il 17/01/21 00:13, Sakari Ailus ha scritto: > > Hi AngeloGioacchino, > > > > On Fri, Jan 15, 2021 at 07:52:33PM +0100, AngeloGioacchino Del Regno wrote: > >> Enhance the feature set for this camera sensor by in rewritin

Re: [PATCH] media: i2c: imx219: Rewrite tables and implement more modes

2021-01-17 Thread AngeloGioacchino Del Regno
Il 17/01/21 00:13, Sakari Ailus ha scritto: Hi AngeloGioacchino, On Fri, Jan 15, 2021 at 07:52:33PM +0100, AngeloGioacchino Del Regno wrote: Enhance the feature set for this camera sensor by in rewriting the entire tables (as they were just meaningless magic register writes) in a similar form,

Re: [PATCH] media: i2c: imx219: Rewrite tables and implement more modes

2021-01-17 Thread AngeloGioacchino Del Regno
Il 17/01/21 16:06, Dave Stevenson ha scritto: Hi AngeloGioacchino Thanks for the patch. Thank you for this review, even if this wasn't properly split. Makes it faster for me to fix things before sending the split series! On Fri, 15 Jan 2021 at 18:52, AngeloGioacchino Del Regno wrote: E

Re: [PATCH] media: i2c: imx219: Rewrite tables and implement more modes

2021-01-17 Thread Dave Stevenson
Hi AngeloGioacchino Thanks for the patch. On Fri, 15 Jan 2021 at 18:52, AngeloGioacchino Del Regno wrote: > > Enhance the feature set for this camera sensor by in rewriting the > entire tables (as they were just meaningless magic register writes) > in a similar form, but giving some names to the

Re: [PATCH] media: i2c: imx219: Rewrite tables and implement more modes

2021-01-16 Thread Sakari Ailus
Hi AngeloGioacchino, On Fri, Jan 15, 2021 at 07:52:33PM +0100, AngeloGioacchino Del Regno wrote: > Enhance the feature set for this camera sensor by in rewriting the > entire tables (as they were just meaningless magic register writes) > in a similar form, but giving some names to the actual regis