Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-30 Thread Richard W.M. Jones
On Thu, May 30, 2013 at 09:22:43AM +1000, NeilBrown wrote: > On Wed, 29 May 2013 15:03:40 +0200 Jens Axboe wrote: > > > On Wed, May 29 2013, Richard W.M. Jones wrote: > > > > > > On Sun, May 19, 2013 at 10:51:45AM -0700, Kent Overstreet wrote: > > > > Sorry for the delay - been vacationing. Repr

Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-29 Thread Jens Axboe
On Thu, May 30 2013, NeilBrown wrote: > On Wed, 29 May 2013 15:03:40 +0200 Jens Axboe wrote: > > > On Wed, May 29 2013, Richard W.M. Jones wrote: > > > > > > On Sun, May 19, 2013 at 10:51:45AM -0700, Kent Overstreet wrote: > > > > Sorry for the delay - been vacationing. Reproduced the original b

Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-29 Thread NeilBrown
On Wed, 29 May 2013 15:03:40 +0200 Jens Axboe wrote: > On Wed, May 29 2013, Richard W.M. Jones wrote: > > > > On Sun, May 19, 2013 at 10:51:45AM -0700, Kent Overstreet wrote: > > > Sorry for the delay - been vacationing. Reproduced the original bug, > > > here's a patch that fixes it: > > > > >

Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-29 Thread Jens Axboe
On Wed, May 29 2013, Richard W.M. Jones wrote: > > On Sun, May 19, 2013 at 10:51:45AM -0700, Kent Overstreet wrote: > > Sorry for the delay - been vacationing. Reproduced the original bug, > > here's a patch that fixes it: > > > > > > commit 402f5db3708b2062795a384a3d8397cf702e27bc > > Author: K

Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-29 Thread Richard W.M. Jones
On Sun, May 19, 2013 at 10:51:45AM -0700, Kent Overstreet wrote: > Sorry for the delay - been vacationing. Reproduced the original bug, > here's a patch that fixes it: > > > commit 402f5db3708b2062795a384a3d8397cf702e27bc > Author: Kent Overstreet > Date: Sun May 19 10:27:07 2013 -0700 > >

Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-28 Thread Ilia Mirkin
On Sun, May 19, 2013 at 1:51 PM, Kent Overstreet wrote: > On Sat, May 18, 2013 at 09:05:15AM +0200, Jens Axboe wrote: >> On Fri, May 17 2013, Calvin Owens wrote: >> > Commit 2f6db2a7 was part of a series that cleaned up mdraid code by >> > replacing explicit re-initialization of struct bio with bi

Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-19 Thread Kent Overstreet
On Sat, May 18, 2013 at 09:05:15AM +0200, Jens Axboe wrote: > On Fri, May 17 2013, Calvin Owens wrote: > > Commit 2f6db2a7 was part of a series that cleaned up mdraid code by > > replacing explicit re-initialization of struct bio with bio_reset(). > > > > In raid5 it incorrectly assumed that a cou

Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

2013-05-18 Thread Jens Axboe
On Fri, May 17 2013, Calvin Owens wrote: > Commit 2f6db2a7 was part of a series that cleaned up mdraid code by > replacing explicit re-initialization of struct bio with bio_reset(). > > In raid5 it incorrectly assumed that a couple initializations of its > members was a full reset, erasing the exi