Re: [PATCH] md: Combine two kmalloc() calls into one in sb_equal()

2016-12-09 Thread Joe Perches
On Fri, 2016-12-09 at 21:30 +, Al Viro wrote: > On Fri, Dec 09, 2016 at 11:05:14AM -0800, Joe Perches wrote: > > On Fri, 2016-12-09 at 19:30 +0100, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date: Fri, 9 Dec 2016 19:09:13 +0100 > > > > > > The function "kmalloc" was called in o

Re: [PATCH] md: Combine two kmalloc() calls into one in sb_equal()

2016-12-09 Thread Al Viro
On Fri, Dec 09, 2016 at 11:05:14AM -0800, Joe Perches wrote: > On Fri, 2016-12-09 at 19:30 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Fri, 9 Dec 2016 19:09:13 +0100 > > > > The function "kmalloc" was called in one case by the function "sb_equal" > > without checking immedi

Re: [PATCH] md: Combine two kmalloc() calls into one in sb_equal()

2016-12-09 Thread Bernd Schubert
On 09.12.2016 19:30, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 9 Dec 2016 19:09:13 +0100 The function "kmalloc" was called in one case by the function "sb_equal" without checking immediately if it failed. Err, your patch actually *replaces* the check. So where did you get the

Re: [PATCH] md: Combine two kmalloc() calls into one in sb_equal()

2016-12-09 Thread Joe Perches
On Fri, 2016-12-09 at 19:30 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 9 Dec 2016 19:09:13 +0100 > > The function "kmalloc" was called in one case by the function "sb_equal" > without checking immediately if it failed. > This issue was detected by using the Coccinelle sof