Re: [PATCH] mbcache: LLVMLinux: Remove double calculation from mbcache

2014-04-29 Thread H. Peter Anvin
On 04/29/2014 06:13 PM, H. Peter Anvin wrote: > I suspect this will generate FP instructions on x86 which will corrupt user > space state. This is thus a critical bug!! It looks like at least x86-64 gcc does the evaluation at compile time and there aren't any fp instructions left in the code. Ho

Re: [PATCH] mbcache: LLVMLinux: Remove double calculation from mbcache

2014-04-29 Thread H. Peter Anvin
I suspect this will generate FP instructions on x86 which will corrupt user space state. This is thus a critical bug!! On April 29, 2014 6:10:39 PM PDT, beh...@converseincode.com wrote: >From: Mark Charlebois > >The call to __builtin_log2 presumes there is a >double log2(double x) function defi