Re: [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled

2019-04-03 Thread Bart Van Assche
On Wed, 2019-04-03 at 13:44 +0100, Will Deacon wrote: > > --- a/kernel/locking/lockdep.c > > +++ b/kernel/locking/lockdep.c > > @@ -4689,8 +4689,7 @@ static void free_zapped_rcu(struct rcu_head *ch) > > return; > > > > raw_local_irq_save(flags); > > - if (!graph_lock()) > > -

Re: [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled

2019-04-03 Thread Will Deacon
On Wed, Apr 03, 2019 at 08:48:02AM -0700, Bart Van Assche wrote: > On Wed, 2019-04-03 at 13:44 +0100, Will Deacon wrote: > > On Tue, Mar 26, 2019 at 12:59:12PM -0700, Bart Van Assche wrote: > > > Commit a0b0fd53e1e6 ("locking/lockdep: Free lock classes that are no > > > longer > > > in use") chang

Re: [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled

2019-04-03 Thread Bart Van Assche
On Wed, 2019-04-03 at 13:44 +0100, Will Deacon wrote: > On Tue, Mar 26, 2019 at 12:59:12PM -0700, Bart Van Assche wrote: > > Commit a0b0fd53e1e6 ("locking/lockdep: Free lock classes that are no longer > > in use") changed the behavior of lockdep_free_key_range() from > > unconditionally zapping loc

Re: [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled

2019-04-03 Thread Will Deacon
On Tue, Mar 26, 2019 at 12:59:12PM -0700, Bart Van Assche wrote: > Commit a0b0fd53e1e6 ("locking/lockdep: Free lock classes that are no longer > in use") changed the behavior of lockdep_free_key_range() from > unconditionally zapping lock classes into only zapping lock classes if > debug_lock == tr