Re: [PATCH] ll_temac: Reset dma descriptors on ndo_open

2013-09-30 Thread Ricardo Ribalda Delgado
Just send a v2 of the patch http://patchwork.ozlabs.org/patch/279339/ Thanks! On Tue, Oct 1, 2013 at 8:01 AM, David Miller wrote: > From: Ricardo Ribalda Delgado > Date: Tue, 1 Oct 2013 07:46:31 +0200 > >> What if I move >>lp->tx_bd_ci = 0; >>lp->tx_bd_next = 0; >>lp->t

Re: [PATCH] ll_temac: Reset dma descriptors on ndo_open

2013-09-30 Thread David Miller
From: Ricardo Ribalda Delgado Date: Tue, 1 Oct 2013 07:46:31 +0200 > What if I move >lp->tx_bd_ci = 0; >lp->tx_bd_next = 0; >lp->tx_bd_tail = 0; >lp->rx_bd_ci = 0; > > to temac_dma_bd_init? Will this be more correct? Yes, that would be a lot better. -- To unsubsc

Re: [PATCH] ll_temac: Reset dma descriptors on ndo_open

2013-09-30 Thread Ricardo Ribalda Delgado
Hello David lp->tx_bd_ci, lp->tx_bd_next... are only initialized to zero on temac_of_probe (inside alloc_etherdev). Those vars are used to index the dma descriptors. The initialization of lp->tx_bd_v[i].app0 = 0; is redundant, because it is already done on dma_zalloc_coherent in temac_dma_bd_

Re: [PATCH] ll_temac: Reset dma descriptors on ndo_open

2013-09-30 Thread David Miller
From: Ricardo Ribalda Delgado Date: Fri, 27 Sep 2013 13:24:28 +0200 > The dma descriptors are only initialized on the probe function. > > If a packet is on the buffer when temac_stop is called, the dma > descriptors can be left on a incorrect status where no other package can > be sent. > > So