Re: [PATCH] libnvdimm: change disk name of virtio pmem disk

2019-08-16 Thread Pankaj Gupta
> > > > This patch adds prefix 'v' in disk name for virtio pmem. > > This differentiates virtio-pmem disks from the pmem disks. > > I don't think the small matter that this device does not support > MAP_SYNC warrants a separate naming scheme. That said I do think we > need to export this attrib

Re: [PATCH] libnvdimm: change disk name of virtio pmem disk

2019-08-15 Thread Dan Williams
On Wed, Jul 31, 2019 at 4:12 AM Pankaj Gupta wrote: > > This patch adds prefix 'v' in disk name for virtio pmem. > This differentiates virtio-pmem disks from the pmem disks. I don't think the small matter that this device does not support MAP_SYNC warrants a separate naming scheme. That said I d

Re: [PATCH] libnvdimm: change disk name of virtio pmem disk

2019-08-12 Thread Pankaj Gupta
Ping. > > This patch adds prefix 'v' in disk name for virtio pmem. > This differentiates virtio-pmem disks from the pmem disks. > > Signed-off-by: Pankaj Gupta > --- > drivers/nvdimm/namespace_devs.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvdim