Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-25 Thread Aaron Lu
On 06/21/2013 07:35 PM, Sergei Shtylyov wrote: > Hello. > > On 21-06-2013 4:55, Aaron Lu wrote: > +void ata_acpi_hotplug_init(struct ata_host *host) +{ + int i; + + for (i = 0; i < host->n_ports; i++) { + struct ata_port *ap = host->ports[i]; +

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-25 Thread Aaron Lu
On 06/21/2013 11:25 PM, James Bottomley wrote: > On Fri, 2013-06-21 at 08:55 +0800, Aaron Lu wrote: >> On 06/20/2013 07:02 PM, Sergei Shtylyov wrote: >>> Hello. >> >> Hi, >> >> Thanks for your comments. >> >>> >>> On 20-06-2013 6:26, Aaron Lu wrote: +void ata_acpi_hotplug_init(struct ata_

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-21 Thread James Bottomley
On Fri, 2013-06-21 at 08:55 +0800, Aaron Lu wrote: > On 06/20/2013 07:02 PM, Sergei Shtylyov wrote: > > Hello. > > Hi, > > Thanks for your comments. > > > > > On 20-06-2013 6:26, Aaron Lu wrote: > >> > >> +void ata_acpi_hotplug_init(struct ata_host *host) > >> +{ > >> + int i; > >> + > >> + f

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-21 Thread Sergei Shtylyov
Hello. On 21-06-2013 4:55, Aaron Lu wrote: +void ata_acpi_hotplug_init(struct ata_host *host) +{ + int i; + + for (i = 0; i < host->n_ports; i++) { + struct ata_port *ap = host->ports[i]; + acpi_handle handle; + struct ata_device *dev; + +

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-20 Thread Aaron Lu
On 06/21/2013 02:29 PM, Tejun Heo wrote: > Hello, > > On Fri, Jun 21, 2013 at 08:55:37AM +0800, Aaron Lu wrote: >>> Please indent this line under the next character after ( above. >> >> Is there a link about this rule? I might have missed something about >> coding style. > > I don't think the

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-20 Thread Tejun Heo
Hello, On Fri, Jun 21, 2013 at 08:55:37AM +0800, Aaron Lu wrote: > > Please indent this line under the next character after ( above. > > Is there a link about this rule? I might have missed something about > coding style. I don't think there's an explicit rule about that and I don't follow i

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-20 Thread Aaron Lu
On 06/20/2013 07:02 PM, Sergei Shtylyov wrote: > Hello. Hi, Thanks for your comments. > > On 20-06-2013 6:26, Aaron Lu wrote: >> >> +void ata_acpi_hotplug_init(struct ata_host *host) >> +{ >> +int i; >> + >> +for (i = 0; i < host->n_ports; i++) { >> +struct ata_port *ap = ho

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-20 Thread Sergei Shtylyov
Hello. On 20-06-2013 6:26, Aaron Lu wrote: From: Liu Jiang Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" removed ACPI dock notification related code, but there's some dead code left, so clean up it. [...] Subject: [PATCH] libata-acpi: add back ACPI based hotplug fun

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-19 Thread Aaron Lu
On 06/18/2013 05:16 PM, Aaron Lu wrote: > On 06/18/2013 02:01 AM, Tejun Heo wrote: >> On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote: >>> On 06/15/2013 11:02 AM, Liu Jiang wrote: From: Liu Jiang Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" remo

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-18 Thread Aaron Lu
On 06/18/2013 02:01 AM, Tejun Heo wrote: > On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote: >> On 06/15/2013 11:02 AM, Liu Jiang wrote: >>> From: Liu Jiang >>> >>> Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" >>> removed ACPI dock notification related code, but the

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-17 Thread Jiang Liu (Gerry)
On 2013/6/18 2:01, Tejun Heo wrote: On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote: On 06/15/2013 11:02 AM, Liu Jiang wrote: From: Liu Jiang Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" removed ACPI dock notification related code, but there's some dead code l

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-17 Thread Tejun Heo
On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote: > On 06/15/2013 11:02 AM, Liu Jiang wrote: > > From: Liu Jiang > > > > Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" > > removed ACPI dock notification related code, but there's some dead > > code left, so clean up i

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-16 Thread Aaron Lu
On 06/15/2013 11:02 AM, Liu Jiang wrote: > From: Liu Jiang > > Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" > removed ACPI dock notification related code, but there's some dead > code left, so clean up it. I never noticed this, but it looks to be the case... I'm not sure